fix: provide clear error when cwd directory does not exist#1407
Open
apoorvdarshan wants to merge 2 commits intogoogle:mainfrom
Open
fix: provide clear error when cwd directory does not exist#1407apoorvdarshan wants to merge 2 commits intogoogle:mainfrom
apoorvdarshan wants to merge 2 commits intogoogle:mainfrom
Conversation
When a nonexistent directory is passed as cwd option, the spawn call would fail with a confusing ENOENT error (or worse, a hanging promise on Deno). This adds an explicit check before spawning to validate the cwd exists and provides a clear, actionable error message. Fixes google#1386
apoorvdarshan
force-pushed
the
fix/cwd-validation-error
branch
from
fc8078c to
8493fe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fs.existsSync(cwd)check inProcessPromise.run()before spawning the child processcwd, it now throws a clear error:The working directory '/path' does not exist.instead of a confusing ENOENT or a hanging promise (on Deno)Fixes #1386
Test plan
provides clear error when cwd does not exist