Fix list_accessible_customers to return JSON-formatted string#14
Open
PhilipJohnBasile wants to merge 1 commit intogoogleads:mainfrom
Open
Conversation
Author
|
@DeanLukies can you take a look at this? |
Collaborator
|
I am honestly puzzled by this, as FastMCPs renders List[str] as one string per row, with a newline between each string. Do you have more context on where you experienced the issue of strings being concatenated? |
|
What is the impact of this change? It seems like it breaks contract to solve a problem elsewhere (FastMCP). Typically, I'd add a JSON version of the function returning the result from the original. In some dark corners, a JSON flag would be added but we don't talk about that. =b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where FastMCP converts list return type into multiple text items that get concatenated.
Changes
Before
After
{ "customer_ids": ["1234567890", "2345678901", "3456789012"], "count": 3 }