feat(EventBuilder): support overriding timestamp at user property and event level #2246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jradcliff
requested changes
Sep 12, 2025
ikuleshov
reviewed
Sep 15, 2025
| "babel-eslint": "^10.0.0", | ||
| "classnames": "^2.3.2", | ||
| "copy-to-clipboard": "^3.3.3", | ||
| "dayjs": "^1.11.18", |
Collaborator
There was a problem hiding this comment.
Can we please double check if it really necessary to introduce another 3rd party library just for the purpose of date manipulation?
Contributor
Author
There was a problem hiding this comment.
Hmm, it seems to be the recommended approach for handling timezones when working with the Material UI date time picker based on the documentation:
ikuleshov
previously approved these changes
Sep 15, 2025
jradcliff
previously approved these changes
Sep 23, 2025
jradcliff
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support overriding timestamp at the user property and event level (already supported at request level).
event validated with request level timestamp
event validated with user property level timestamp
event validated with no user property level timestamp