feat(EventBuilder): support overriding timestamp at user property and event level #2246
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,91 +1,106 @@ | ||
| import * as React from "react" | ||
|
|
||
| import TextField from "@mui/material/TextField" | ||
| import { Parameter as ParameterT } from "./types" | ||
| import { ShowAdvancedCtx } from "." | ||
| import { | ||
| IconButton, | ||
| Tooltip, | ||
| Grid | ||
| } from "@mui/material" | ||
| import { Delete } from "@mui/icons-material" | ||
| import TimestampPicker from "./TimestampPicker" | ||
| import { TimestampScope } from "@/constants" | ||
|
|
||
| interface Props { | ||
| parameter: ParameterT | ||
| idx: number | ||
| setParamName: (name: string) => void | ||
| setParamValue: (value: string) => void | ||
| setParamTimestamp: (idx: number, value: number | undefined) => void | ||
| removeParam: () => void | ||
| allowTimestampOverride: boolean | ||
| } | ||
|
|
||
| const Parameter: React.FC<Props> = ({ | ||
| parameter, | ||
| idx, | ||
| setParamName, | ||
| setParamValue, | ||
| setParamTimestamp, | ||
| removeParam, | ||
| allowTimestampOverride, | ||
| }) => { | ||
| const showAdvanced = React.useContext(ShowAdvancedCtx) | ||
|
|
||
| const [name, setName] = React.useState(parameter.name) | ||
| const [value, setValue] = React.useState(parameter.value || "") | ||
| const [timestamp, setTimestamp] = React.useState( | ||
| parameter.timestamp_micros?.toString() || "" | ||
| ) | ||
|
|
||
| React.useEffect(() => { | ||
| const num = parseInt(timestamp, 10) | ||
| setParamTimestamp(idx, isNaN(num) ? undefined : num) | ||
| }, [timestamp, setParamTimestamp, idx]) | ||
|
|
||
| const inputs = ( | ||
| <Grid container spacing={1}> | ||
| <Grid item xs> | ||
| <TextField | ||
| id={`#/events/0/params/${name}`} | ||
| variant="outlined" | ||
| size="small" | ||
| value={name} | ||
| onChange={e => setName(e.target.value)} | ||
| onBlur={() => setParamName(name)} | ||
| label="name" | ||
| fullWidth | ||
| /> | ||
| </Grid> | ||
| <Grid item xs> | ||
| <TextField | ||
| variant="outlined" | ||
| size="small" | ||
| value={value || ""} | ||
| InputLabelProps={{ | ||
| ...(parameter.exampleValue === undefined ? {} : { shrink: true }), | ||
| }} | ||
| onChange={e => setValue(e.target.value)} | ||
| onBlur={() => setParamValue(value)} | ||
| label={`${parameter.type} value`} | ||
| placeholder={parameter.exampleValue?.toString()} | ||
| fullWidth | ||
| /> | ||
| </Grid> | ||
| {allowTimestampOverride && ( | ||
| <Grid item xs={12}> | ||
| <TimestampPicker | ||
| timestamp={timestamp} | ||
| scope={TimestampScope.USER_PROPERTY} | ||
| setTimestamp={setTimestamp} | ||
| /> | ||
| </Grid> | ||
| )} | ||
| </Grid> | ||
| ) | ||
| if (showAdvanced) { | ||
| return ( | ||
| <Grid container spacing={1} alignItems="flex-start"> | ||
| <Grid item> | ||
| <Tooltip title="remove parameter"> | ||
| <IconButton onClick={removeParam}> | ||
| <Delete /> | ||
| </IconButton> | ||
| </Tooltip> | ||
| </Grid> | ||
| <Grid item xs> | ||
| {inputs} | ||
| </Grid> | ||
| </Grid> | ||
| ) | ||
| } | ||
| return inputs | ||
| } | ||
|
|
||
| export default Parameter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please double check if it really necessary to introduce another 3rd party library just for the purpose of date manipulation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it seems to be the recommended approach for handling timezones when working with the Material UI date time picker based on the documentation: