Skip to content

chore(EventBuilder): update character limits for session_id, session_number #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lindsey-volta merged 5 commits into from
Oct 8, 2025
Merged

chore(EventBuilder): update character limits for session_id, session_number #2262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
217df5f
update character limits for event parameters
lindsey-volta Oct 2, 2025
8fb5d5b
update wording in tests
lindsey-volta Oct 2, 2025
f66aecd
Merge remote-tracking branch 'origin/main' into session-id-char-limit
lindsey-volta Oct 7, 2025
4e8bc01
remove character limit validation on event parameter values
lindsey-volta Oct 7, 2025
055a90e
remove commented out code
lindsey-volta Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/custom.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ export const customSchema = {
"type": "object",
"required": [],
"maxProperties": 25,
"patternProperties": {
".": {
"maxLength": 100
}
},
"propertyNames": {
"pattern": "^(?!ga_|google_|firebase_)[A-Za-z][A-Za-z0-9_]*$",
"maxLength": 40
Expand Down
5 changes: 0 additions & 5 deletions src/components/ga4/EventBuilder/ValidateEvent/schemas/schemaBuilder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,6 @@ export const buildEvents = () => {
"^(?!ga_|google_|firebase_)[A-Za-z][A-Za-z0-9_]*$",
"maxLength":
40
},
"patternProperties": {
".": {
"maxLength": 100
}
}
}
}
Expand Down
4 changes: 1 addition & 3 deletions src/components/ga4/EventBuilder/index.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,13 +176,11 @@ describe("Event Builder", () => {
// event categories so if it's broken, it's probably fine to just
// change the expected values.
const ecInput = within(eventCategory).getByRole("combobox")
//eventCategory.focus()
renderer.fireEvent.change(ecInput, {
target: { value: "All apps" },
})

const enInput = within(eventName).getByRole("combobox")
//eventCategory.focus()
renderer.fireEvent.change(enInput, {
target: { value: "campaign_details" },
})
Expand Down Expand Up @@ -227,4 +225,4 @@ describe("Event Builder", () => {
expect(adImpression).toBeNull()
})
})
})
})
Loading