Skip to content

build: install Go during build#704

Merged
olavloite merged 1 commit intomainfrom
install-go
Feb 24, 2026
Merged

build: install Go during build#704
olavloite merged 1 commit intomainfrom
install-go

Conversation

@olavloite
Copy link
Collaborator

No description provided.

@olavloite olavloite requested review from a team as code owners February 24, 2026 18:09
@gemini-code-assist
Copy link

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the installation of Go into the project's build process. By adding the necessary steps to the main build script and providing a dedicated installation script, it ensures that the Go runtime is consistently available for subsequent build tasks, thereby standardizing the build environment setup.

Highlights

  • Go Installation Integrated: The build.sh script now includes steps to download, install, and configure Go version 1.26.0 for Windows AMD64.
  • Dedicated Installation Script: A new script, install-go.sh, has been introduced to encapsulate the Go installation logic, making it reusable.
  • Silent Installation and PATH Update: Go is installed silently using msiexec.exe, and the system's PATH environment variable is updated for the current script session.
Changelog
  • build.sh
    • Integrated Go installation steps, including downloading, silent installation, and PATH configuration.
  • install-go.sh
    • Created a new script to handle the silent download and installation of Go version 1.26.0 for Windows AMD64, along with PATH updates.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/install-go.yml
Activity
  • No human activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a Go installation step into the build process. While the addition of install-go.sh is a good step towards modularity, the logic is currently duplicated in build.sh. Furthermore, the specified Go version is invalid, and there are potential issues with how curl and msiexec are invoked. I have provided suggestions to centralize the logic and improve robustness.

@olavloite olavloite merged commit 70c2a2e into main Feb 24, 2026
19 checks passed
@olavloite olavloite deleted the install-go branch February 24, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants