fix: Fix function spec for Response.decode/2
#12734
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The input type for `GoogleApi.Gax.Response.decode/2` was missing the error case (which is explicitly handled in the first function clause). The return type incorrectly specifies that the error type must be a `Tesla.Env.t()` when in fact it may return any type (for example `:timeout` is returned when the Mint HTTP client times out).
bernardd
changed the title
Response.decode/2Response.decode/2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input type for
GoogleApi.Gax.Response.decode/2was missing the error case (which is explicitly handled in the first function clause).The return type incorrectly specifies that the error type must be a
Tesla.Env.t()when in fact it may return any type (for example:timeoutis returned when the Mint HTTP client times out).