-
Notifications
You must be signed in to change notification settings - Fork 24
chore(deps): update dotnet monorepo (major) #926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update dotnet monorepo (major) #926
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant upgrade of the project's .NET dependencies, moving from .NET 8 to .NET 9. This includes updating the core .NET SDK and several key Microsoft libraries to their latest major versions. The update aims to leverage the newest features, performance enhancements, and security improvements offered by the .NET 9 ecosystem, ensuring the project remains modern and well-supported. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request proposes a major update of the .NET dependencies, moving to the .NET 9 Preview SDK and several core packages to version 10.0.0. These package versions appear to be from a non-public, pre-release feed for a future version of .NET. This introduces significant risks of instability and breaking changes, especially with the large version jump for Microsoft.Bcl.AsyncInterfaces from v6 to v10. I have left comments highlighting the risks of using a preview SDK and highly experimental package versions. I recommend carefully evaluating the need for such an early adoption and considering using official .NET 9 preview packages as an alternative if aligning with the new SDK is the goal.
Directory.Packages.props
Outdated
| <PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="10.0.0" /> | ||
| <PackageVersion Include="Microsoft.CodeAnalysis.CSharp" Version="4.14.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.11" /> | ||
| <PackageVersion Include="System.Collections.Immutable" Version="9.0.11" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.0" /> | ||
| <PackageVersion Include="System.Collections.Immutable" Version="10.0.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This updates several core .NET packages to version 10.0.0. This version appears to be from a pre-release feed for a future, unannounced version of .NET, as public releases are currently on version 8 (stable) and 9 (preview).
Using such early, non-public versions is highly risky and can lead to:
- Breaking Changes: Major version jumps, especially from v6 to v10 for
Microsoft.Bcl.AsyncInterfaces, are very likely to contain significant breaking API changes. - Instability: These builds are not guaranteed to be stable.
- Lack of Support: You will not find community support or official documentation for issues encountered with these versions.
It is strongly recommended to use official stable or preview releases from NuGet.org. If the goal is to align with the .NET 9 SDK, consider using the latest .NET 9 preview packages instead of these .NET 10 packages.
global.json
Outdated
| { | ||
| "sdk": { | ||
| "version": "8.0.415", | ||
| "version": "9.0.306", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the .NET SDK to version 9.0.306 moves the project to a .NET 9 Preview SDK. While this might be intentional for testing upcoming features, it's important to be aware that preview SDKs can be unstable and are not recommended for production environments. This could introduce unexpected build issues or runtime behavior. Please ensure that this change is intentional and that the team is prepared to handle potential instability from using a preview SDK.
|
@amanda-tarafa Another one I think we want to ignore - although we probably could take them other than global.json. Maybe figure out when to update to the .NET 10 SDK and do everything at that point? |
9069aba to
40d6fba
Compare
|
Let's keep it around for now. |
7e0cba5 to
b07de28
Compare
5a44fb6 to
36f0aab
Compare
36f0aab to
6361c36
Compare
This PR contains the following updates:
6.0.0→10.0.14.14.0→5.0.09.0.11→10.0.19.0.11→10.0.18.0.416→10.0.101Release Notes
dotnet/dotnet (Microsoft.Bcl.AsyncInterfaces)
v10.0.1v9.0.7: .NET 9.0.7You can build .NET 9.0 from the repository by cloning the release tag
v9.0.7and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.6: .NET 9.0.6You can build .NET 9.0 from the repository by cloning the release tag
v9.0.6and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.5: .NET 9.0.5You can build .NET 9.0 from the repository by cloning the release tag
v9.0.5and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.4: .NET 9.0.4You can build .NET 9.0 from the repository by cloning the release tag
v9.0.4and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.3: .NET 9.0.3You can build .NET 9.0 from the repository by cloning the release tag
v9.0.3and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.2: .NET 9.0.2You can build .NET 9.0 from the repository by cloning the release tag
v9.0.2and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.1: .NET 9.0.1You can build .NET 9.0 from the repository by cloning the release tag
v9.0.1and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v9.0.0: .NET 9.0.0You can build .NET 9.0 from the repository by cloning the release tag
v9.0.0and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dot.net/release-key-2023
v8.0.0: .NET 8.0You can build .NET 8.0 from the repository by cloning the release tag
v8.0.0and following the build instructions in the main README.md.Alternatively, you can build from the sources attached to this release directly.
More information on this process can be found in the dotnet/dotnet repository.
Attached are PGP signatures for the GitHub generated tarball and zipball. You can find the public key at https://dotnet.microsoft.com/download/dotnet/release-key-2023.asc
dotnet/sdk (dotnet-sdk)
v10.0.101: .NET 10.0.1Compare Source
Release
What's Changed
vs2022Image rejecting preview sdks, failing to resolve sdks by @nagilson in #51558vs2022Image rejecting preview sdks, failing to resolve sdks by @github-actions[bot] in #51621Full Changelog: dotnet/sdk@v10.0.100...v10.0.101
v10.0.100: .NET 10.0.0Compare Source
Release
What's Changed
unsetby @github-actions[bot] in #509632801306by @dotnet-bot in #509742802347by @dotnet-bot in #51014dnx --helpand tool commands to use valid .NET tool examples by @github-actions[bot] in #510422804587by @dotnet-bot in #510312810403by @dotnet-bot in #51160.slnxto default.editorconfigtemplate by @github-actions[bot] in #510952812555by @dotnet-bot in #511882813133by @dotnet-bot in #51195Full Changelog: dotnet/sdk@v10.0.100-rc.2.25502.107...v10.0.100
v9.0.308Compare Source
v9.0.307: .NET 9.0.11Compare Source
Release
What's Changed
Full Changelog: dotnet/sdk@v9.0.306...v9.0.307
[
v9.0.306](https://redirect.github.com/dotnet/sdk/releases/tConfiguration
📅 Schedule: Branch creation - "before 8am" in timezone Europe/London, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.