Skip to content

Conversation

@jskeet
Copy link
Collaborator

@jskeet jskeet commented Nov 17, 2025

This avoids a conflict with .NET 10

@jskeet jskeet requested a review from a team as a code owner November 17, 2025 13:57
@gemini-code-assist
Copy link

Summary of Changes

Hello @jskeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a potential conflict with .NET 10 by eliminating the System.Linq.Async library. The change involves updating project dependencies and refactoring asynchronous iteration patterns in generated code to utilize the built-in await foreach syntax, improving code consistency and reducing external dependencies.

Highlights

  • Dependency Removal: The System.Linq.Async dependency has been completely removed from the project, including from Directory.Packages.props and various .csproj files.
  • Asynchronous Iteration Update: Generated code snippets have been updated to replace ForEachAsync calls with the native C# await foreach construct for asynchronous iteration, leveraging modern language features.
  • Code Generation Logic: The RoslynBuilder and SnippetCodeGenerator have been modified to support the generation of await foreach statements, ensuring future generated code adheres to the new asynchronous iteration pattern.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the dependency on System.Linq.Async to avoid potential conflicts with future .NET versions. The implementation correctly replaces ForEachAsync calls with the native await foreach construct, which is a good modernization of the codebase. The code generator and all relevant generated files, including project files and snippets, have been updated consistently. The changes are clean, correct, and well-executed. I have no further comments.

This allows us to remove the dependency on System.Linq.Async entirely.
Test changes are in the next commit.

Towards googleapis/google-cloud-dotnet#15037
(Other changes are just in terms of the BOM.)
Copy link
Contributor

@amanda-tarafa amanda-tarafa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jskeet jskeet merged commit 61a56a5 into googleapis:main Nov 17, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants