Skip to content

chore: depend on stable version of google.shopping.type #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2025
Merged

chore: depend on stable version of google.shopping.type #2423

merged 2 commits into from
Aug 28, 2025

Conversation

vchudnov-g
Copy link
Contributor

No description provided.

@vchudnov-g vchudnov-g requested a review from a team as a code owner August 13, 2025 22:50
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 13, 2025
@vchudnov-g vchudnov-g added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed size: xs Pull request size is extra small. labels Aug 13, 2025
@vchudnov-g
Copy link
Contributor Author

Do not merge until google-shopping-type 1.0.0 has been published to PyPI (https://pypi.org/project/google-shopping-type/#history). I am attempting to do this by triggering release-please on googleapis/google-cloud-python#14230; no luck thus far.

@vchudnov-g
Copy link
Contributor Author

OK, l google-shopping-type 1.0.0 has been published to PyPI https://pypi.org/project/google-shopping-type/1.0.0/, so this PR is unblocked. We should merge and release the generator.

@vchudnov-g vchudnov-g removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 13, 2025
@vchudnov-g vchudnov-g mentioned this pull request Aug 13, 2025
Closed
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 28, 2025
@vchudnov-g vchudnov-g enabled auto-merge (squash) August 28, 2025 00:40
@vchudnov-g vchudnov-g merged commit e8154bb into main Aug 28, 2025
124 checks passed
@vchudnov-g vchudnov-g deleted the vchudnov-g-dependon-stable-google-shopping-type branch August 28, 2025 01:01
parthea pushed a commit that referenced this pull request Aug 28, 2025
@vchudnov-g @parthea
chore: depend on stable version of google.shopping.type (#2423)
84b0a23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees

@parthea parthea

Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchudnov-g @parthea