Skip to content
This repository was archived by the owner on Mar 20, 2018. It is now read-only.

Re-raise unrecognized exceptions on retry. #168

Open
lukesneeringer wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Re-raise unrecognized exceptions on retry. #168

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e78db7
Re-raise unrecognized exceptions on retry.
Mar 2, 2017
547f9d9
Make tests catch appropriate custom errors.
Mar 2, 2017
145a00d
Update error handling to catch and wrap RpcError.
Mar 2, 2017
09b3342
Fix Travis.
Mar 2, 2017
767a960
Merge branch 'master' into reraise-unknown-retry-exc
Mar 2, 2017
1251b57
Remove errors.CustomException, whose meaning has changed.
Mar 2, 2017
c725aa8
Fix __all__.
Mar 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions google/gax/retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,11 @@ def inner(*args):
return to_call(*args)
except Exception as exception: # pylint: disable=broad-except
code = config.exc_to_code(exception)

# Do not be greedy; if this is an exception that we do
Copy link
Contributor

@geigerj geigerj Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'm not sure "do not be greedy" is going to make sense to someone reading this code without knowledge of its history.

# not know for sure should be retried, simply re-raise it.
if code not in retry_options.retry_codes:
raise errors.RetryError(
'Exception occurred in retry method that was not'
' classified as transient', exception)
raise

# pylint: disable=redefined-variable-type
exc = errors.RetryError(
Expand Down