feat(server): add Tool call error categories#2387
Conversation
Summary of ChangesHello @duwenxin99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a structured error handling mechanism by defining distinct error categories for agent and server-side issues. This foundational change aims to improve the clarity and diagnosability of errors within the system, making it easier to identify the source of a problem and streamline debugging efforts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces new error types, AgentError and ServerError, to categorize errors originating from the agent or the server. The changes are well-contained in a new errors.go file. My feedback includes suggestions to improve the new error abstractions by making the ToolboxError interface more specific and by adding support for Go's standard error wrapping to ServerError.
Create Agent vs Server error types to distinguish between the two types.