Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the skill generator template to invoke tools via npx @toolbox-sdk/server instead of a local binary and adds a custom execution path for Windows. Feedback includes removing the now-unused execSync import, addressing the regression in local development support, and replacing the fragile Windows bypass logic with the standard shell: true option in spawn for better reliability.
Contributor
|
Testing it for macOS |
averikitsch
added
the
release candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the
skills-generatecommand to allow it generate skills that relies on npx for tool invocation, without the need of having a toolbox binary.More specifically, a new --invocation-mode flag (defaulting to binary, with support for npx) and a --toolbox-version flag to pin the @toolbox-sdk/server package version (defaulting to the current numerical version in version.txt).