feat: Support ExternalAccountAuthorizedUserCredential#2950
Merged
amanda-tarafa merged 3 commits intogoogleapis:mainfrom Apr 1, 2025
Merged
feat: Support ExternalAccountAuthorizedUserCredential#2950amanda-tarafa merged 3 commits intogoogleapis:mainfrom
amanda-tarafa merged 3 commits intogoogleapis:mainfrom
Conversation
jskeet
approved these changes
Apr 1, 2025
Collaborator
jskeet
left a comment
jskeet
left a comment
There was a problem hiding this comment.
Tiny comments, but generally fine :)
|
|
||
| protected override async Task<HttpResponseMessage> SendAsyncCore(HttpRequestMessage request, CancellationToken taskCancellationToken) | ||
| { | ||
| if (request.Content != null) |
Collaborator
There was a problem hiding this comment.
Perhaps we should set LatestRequestContent either way, setting it to null if there was no content?
| @@ -0,0 +1,103 @@ | |||
| /* | |||
| Copyright 2022 Google LLC | |||
amanda-tarafa
commented
Apr 1, 2025
Contributor
Author
amanda-tarafa
left a comment
amanda-tarafa
left a comment
There was a problem hiding this comment.
Comments addressed in upcoming commits.
I'll rebase and merge on green.
| @@ -0,0 +1,103 @@ | |||
| /* | |||
| Copyright 2022 Google LLC | |||
|
|
||
| protected override async Task<HttpResponseMessage> SendAsyncCore(HttpRequestMessage request, CancellationToken taskCancellationToken) | ||
| { | ||
| if (request.Content != null) |
amanda-tarafa
force-pushed
the
authorized-user-cred
branch
from
6b32f1e to
cfc39bb
Compare
amanda-tarafa
force-pushed
the
authorized-user-cred
branch
from
cfc39bb to
3ee051d
Compare
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Jun 6, 2025
Features: - googleapis#2950 Support ExternalAccountAuthorizedUserCredential - googleapis#2921 Support ID token for SAs in other than the default universe domain
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Jun 9, 2025
Features: - googleapis#2950 Support ExternalAccountAuthorizedUserCredential - googleapis#2921 Support ID token for SAs in other than the default universe domain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.