feat: API regeneration: release-2025-11-05.09-01-57 #3067
Conversation
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the API definitions for a wide range of Google Cloud services, ensuring that the generated client libraries are synchronized with the most current API specifications. The changes encompass the introduction of new fields for enhanced artifact tracking and identity management, along with significant improvements in API documentation and the addition of new operational features for services like Storage Batch Operations and VM Migration. These updates collectively aim to improve the functionality, clarity, and integration capabilities of the affected APIs. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is an automated API regeneration, which introduces new features and improves documentation across several services. The changes are consistent with what's expected from such an update. I've identified a minor typo in the descriptions within the merchantapi discovery documents that should be corrected. Otherwise, the changes look good.
| }, | ||
| "SupplementalProductDataSource": { | ||
| "description": "The supplemental data source for local and online products. After creation, you should make sure to link the supplemental product data source into one or more primary product data sources.", | ||
| "description": "The [supplemental data source](https://developers.google.com/merchant/api/guides/data-sources/api-sources#link-supplemental-data-source) for local and online products. After creation,you should make sure to link the supplemental product data source into one or more primary product data sources.", |
There was a problem hiding this comment.
There is a minor typo in the description. The text creation,you is missing a space after the comma and should be creation, you.
| "description": "The [supplemental data source](https://developers.google.com/merchant/api/guides/data-sources/api-sources#link-supplemental-data-source) for local and online products. After creation,you should make sure to link the supplemental product data source into one or more primary product data sources.", | |
| "description": "The [supplemental data source](https://developers.google.com/merchant/api/guides/data-sources/api-sources#link-supplemental-data-source) for local and online products. After creation, you should make sure to link the supplemental product data source into one or more primary product data sources.", |
| }, | ||
| "SupplementalProductDataSource": { | ||
| "description": "The supplemental data source for local and online products. After creation, you should make sure to link the supplemental product data source into one or more primary product data sources.", | ||
| "description": "The [supplemental data source](https://developers.google.com/merchant/api/guides/data-sources/api-sources#link-supplemental-data-source) for local and online products. After creation,you should make sure to link the supplemental product data source into one or more primary product data sources.", |
There was a problem hiding this comment.
There is a minor typo in the description. The text creation,you is missing a space after the comma and should be creation, you.
| "description": "The [supplemental data source](https://developers.google.com/merchant/api/guides/data-sources/api-sources#link-supplemental-data-source) for local and online products. After creation,you should make sure to link the supplemental product data source into one or more primary product data sources.", | |
| "description": "The [supplemental data source](https://developers.google.com/merchant/api/guides/data-sources/api-sources#link-supplemental-data-source) for local and online products. After creation, you should make sure to link the supplemental product data source into one or more primary product data sources.", |
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents an automated API regeneration that updates the client libraries for numerous Google Cloud services. It brings in new API features, such as enhanced artifact tracking in Container Analysis, expanded trust boundary information in IAM Credentials, and new dry-run functionality in Storage Batch Operations. The update also includes various documentation improvements, such as clearer descriptions and explicit deprecation notices, ensuring the client libraries remain current and accurately reflect the underlying API capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request appears to be an automated API regeneration. It includes updates to several Discovery JSON files, which in turn lead to regenerated C# client libraries. The changes include adding new fields and endpoints, updating descriptions for clarity, and bumping package versions. My review focused on the changes in the Discovery JSON files as they are the source of truth. I found a couple of issues: an inconsistency in a required parameter in the Healthcare API, and an opportunity to reduce schema duplication in the IAM Credentials API. The rest of the changes appear correct and improve the API definitions.
| "description": "Required. The FHIR resource type used to organize exported resources. Only supports \"Patient\". When organized by Patient resource, output files are grouped as follows: * Patient file(s) containing the Patient resources. Each Patient is sequentially followed by all resources the Patient references, and all resources that reference the Patient (equivalent to a GetPatientEverything request). * Individual files grouped by resource type for resources in the Group's member field and the Group resource itself. Resources may be duplicated across multiple Patients. For example, if two Patient resources reference the same Organization resource, it will appear twice, once after each Patient. The Group resource from the request does not appear in the Patient files.", | ||
| "location": "query", | ||
| "type": "string" |
There was a problem hiding this comment.
The description for organizeOutputBy now correctly states that it is "Required". However, the parameter itself is not marked as required in the schema (i.e., it's missing "required": true). This inconsistency can be misleading for clients and tools that generate code from this discovery document. To ensure correctness and a clear API contract, this parameter should be explicitly marked as required.
"description": "Required. The FHIR resource type used to organize exported resources. Only supports \"Patient\". When organized by Patient resource, output files are grouped as follows: * Patient file(s) containing the Patient resources. Each Patient is sequentially followed by all resources the Patient references, and all resources that reference the Patient (equivalent to a GetPatientEverything request). * Individual files grouped by resource type for resources in the Group's member field and the Group resource itself. Resources may be duplicated across multiple Patients. For example, if two Patient resources reference the same Organization resource, it will appear twice, once after each Patient. The Group resource from the request does not appear in the Patient files.",
"location": "query",
"required": true,
"type": "string"| "description": "Required. The FHIR resource type used to organize exported resources. Only supports \"Patient\". When organized by Patient resource, output files are grouped as follows: * Patient file(s) containing the Patient resources. Each Patient is sequentially followed by all resources the Patient references, and all resources that reference the Patient (equivalent to a GetPatientEverything request). * Individual files grouped by resource type for resources in the Group's member field and the Group resource itself. Resources may be duplicated across multiple Patients. For example, if two Patient resources reference the same Organization resource, it will appear twice, once after each Patient. The Group resource from the request does not appear in the Patient files.", | ||
| "location": "query", | ||
| "type": "string" |
There was a problem hiding this comment.
The description for organizeOutputBy now correctly states that it is "Required". However, the parameter itself is not marked as required in the schema (i.e., it's missing "required": true). This inconsistency can be misleading for clients and tools that generate code from this discovery document. To ensure correctness and a clear API contract, this parameter should be explicitly marked as required.
"description": "Required. The FHIR resource type used to organize exported resources. Only supports \"Patient\". When organized by Patient resource, output files are grouped as follows: * Patient file(s) containing the Patient resources. Each Patient is sequentially followed by all resources the Patient references, and all resources that reference the Patient (equivalent to a GetPatientEverything request). * Individual files grouped by resource type for resources in the Group's member field and the Group resource itself. Resources may be duplicated across multiple Patients. For example, if two Patient resources reference the same Organization resource, it will appear twice, once after each Patient. The Group resource from the request does not appear in the Patient files.",
"location": "query",
"required": true,
"type": "string"| "ServiceAccountAllowedLocations": { | ||
| "description": "Represents a list of allowed locations for given service account.", | ||
| "id": "ServiceAccountAllowedLocations", | ||
| "properties": { | ||
| "encodedLocations": { | ||
| "description": "Output only. The hex encoded bitmap of the trust boundary locations", | ||
| "readOnly": true, | ||
| "type": "string" | ||
| }, | ||
| "locations": { | ||
| "description": "Output only. The human readable trust boundary locations. For example, [\"us-central1\", \"europe-west1\"]", | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "readOnly": true, | ||
| "type": "array" | ||
| } | ||
| }, | ||
| "type": "object" |
There was a problem hiding this comment.
The schemas for ServiceAccountAllowedLocations, WorkforcePoolAllowedLocations (lines 505-523), and WorkloadIdentityPoolAllowedLocations (lines 525-543) are structurally identical. To improve maintainability and reduce redundancy, consider defining a single, reusable schema (e.g., AllowedLocations). This would make the API definition more concise and easier to manage, especially for future updates. If these schemas are intended to diverge in the future, this duplication might be acceptable, but a common base could still be beneficial.
2 participants
Changes in this PR will be published to Nuget on the next release cycle.