-
Notifications
You must be signed in to change notification settings - Fork 549
feat: API regeneration: release-2025-11-10.20-38-33 #3070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request encompasses a broad API regeneration across multiple Google Cloud services. The primary goal is to synchronize the client libraries with the latest API definitions, introducing new features, refining existing functionalities, and enhancing documentation. These changes ensure that developers have access to the most current and accurate API surface for their applications, with updates ranging from new data models and methods to improved regional support and clearer field descriptions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request represents a routine API regeneration across numerous Google Cloud services. The changes encompass the introduction of new API methods and resources, updates to existing field descriptions for improved clarity, and the addition of new configuration options and reporting capabilities. Key updates include new device management features in Chrome Management, enhanced cluster upgrade mechanisms in GKE Hub, and significant expansions to the Workspace Events API for agent-to-agent communication and task management. These updates ensure that the API definitions remain current with service offerings and provide developers with access to the latest functionalities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request encompasses a routine API regeneration cycle, updating the Discovery JSON files for a wide array of Google Cloud services. These updates introduce new API methods, refine existing resource definitions, enhance documentation, and expand regional support, ensuring that client libraries remain synchronized with the evolving platform capabilities. Key changes include new reporting features in Chrome Management, advanced registry configurations in GKE, and significant additions to the Workspace Events API for improved agent interaction. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a wide range of updates from an API regeneration across multiple services. The changes primarily consist of adding new features, such as new endpoints and methods for services like App Engine, Chrome Management, Cloud Shell, GKE Hub, and Migration Center. There are also significant schema additions to support new functionalities, including rollback-safe upgrades in GKE, AWS KMS integration in Data Manager, and enhanced reporting in OS Config. Additionally, the PR includes numerous clarifications in descriptions, deprecation of old fields, and consistency improvements like marking read-only fields explicitly. The corresponding C# client libraries have been updated to reflect these API changes. Overall, the changes are extensive but appear consistent with an automated API regeneration process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a substantial set of automated API regeneration changes across numerous services. The updates encompass API revision bumps, the addition of new endpoints, methods, and schemas, as well as clarifications and deprecations in descriptions. These modifications are consistently applied across different API versions (v1, v1alpha, v1beta) where relevant. The corresponding C# client libraries and project files have also been updated to reflect these API changes, including necessary version increments for the packages. After a comprehensive review, all changes appear to be correct and part of a standard, coordinated API release cycle. I have not identified any issues requiring attention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated API regeneration, introducing a wide range of updates across multiple services. Key changes include the addition of new features and endpoints for services like App Engine, Chrome Management, Container, GKE Hub, and Workspace Events, along with numerous documentation improvements, field deprecations, and updated regional endpoints. The generated C# client libraries and their dependencies have also been updated accordingly. The changes are extensive but appear to be consistent and correctly generated as part of a standard release cycle.
|
@amanda-tarafa Any idea why this has come later than normal today? Will approve, but let you merge. |
|
@robertvoinescu-work is looking into why, but it seems to be because of the known Discovery generator error for structs/any. |
Changes in this PR will be published to Nuget on the next release cycle.