Skip to content

Conversation

@renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Confidence
Microsoft.NET.Test.Sdk 18.0.0 -> 18.0.1 age confidence

Release Notes

microsoft/vstest (Microsoft.NET.Test.Sdk)

v18.0.1

What's Changed

Fixing an issue with loading covrun64.dll on systems that have .NET 10 SDK installed: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/10.0/code-coverage-dynamic-native-instrumentation

Internal changes

Full Changelog: microsoft/vstest@v18.0.0...v18.0.1


Configuration

📅 Schedule: Branch creation - "before 8am every weekday" in timezone Europe/London, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team as a code owner November 12, 2025 03:41
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine dependency update for the Microsoft.NET.Test.Sdk package to its latest patch version. This ensures that the project's testing infrastructure benefits from the latest bug fixes and stability improvements, specifically addressing a known compatibility issue with code coverage tools on newer .NET SDK environments. The change is limited to updating package references in relevant test project files.

Highlights

  • Dependency Update: The Microsoft.NET.Test.Sdk package has been updated from version 18.0.0 to 18.0.1 across multiple test projects.
  • Bug Fix: This update includes a fix for an issue where covrun64.dll failed to load on systems with the .NET 10 SDK installed, by disabling DynamicNative instrumentation by default.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Microsoft.NET.Test.Sdk dependency from version 18.0.0 to 18.0.1 across three test projects. This is a patch update that fixes an issue with code coverage tooling, so it's a safe and recommended change. While the update itself is correct, I've identified an opportunity to improve the project's long-term maintainability by centralizing NuGet package version management. My review includes a detailed suggestion on how to achieve this using a Directory.Build.props file, which would simplify future dependency updates and ensure consistency across the solution.


<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this version update is correct, I've noticed that this dependency and others (like xunit) are declared with explicit versions in multiple .csproj files. This can make dependency management cumbersome and error-prone.

To improve maintainability and ensure version consistency across all test projects, you could centralize package version management. A common way to achieve this in .NET projects is by using a Directory.Build.props file at the root of your solution or a shared parent directory. This would also be a good place to standardize other properties like LangVersion, which is currently inconsistent across projects (latest vs 10.0).

For example, you could create a Directory.Build.props file with the following content:

<Project>
  <PropertyGroup>
    <LangVersion>latest</LangVersion>
  </PropertyGroup>
  <ItemGroup>
    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
    <PackageVersion Include="xunit" Version="2.9.3" />
    <PackageVersion Include="Xunit.Combinatorial" Version="1.6.24" />
    <!-- Note: Aligning xunit.runner.visualstudio version -->
    <PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />
    <PackageVersion Include="Xunit.SkippableFact" Version="1.5.23" />
    <PackageVersion Include="BouncyCastle.Cryptography" Version="2.6.2" />
    <!-- etc. for other common packages -->
  </ItemGroup>
</Project>

Then, in your .csproj files, you can omit the Version attribute from the <PackageReference> elements. MSBuild will automatically use the versions defined in Directory.Build.props.

<PackageReference Include="Microsoft.NET.Test.Sdk" />

This would centralize version definitions, making future updates much simpler and ensuring consistency. As part of this, you could align the xunit.runner.visualstudio version, which is currently 2.4.3 in this project but 2.8.2 in Google.Apis.IntegrationTests.csproj.

@jskeet jskeet merged commit 4f836e5 into googleapis:main Nov 12, 2025
4 checks passed
@renovate-bot renovate-bot deleted the renovate/vstest-monorepo branch November 12, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants