-
Notifications
You must be signed in to change notification settings - Fork 549
chore: Update version 1.72.0 -> 1.73.0 #3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update version 1.72.0 -> 1.73.0 #3076
Conversation
Summary of ChangesHello @robertvoinescu-work, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine version update for the project, incrementing the version number from 1.72.0 to 1.73.0. This change is crucial for addressing a known dependency issue, aiming to resolve a problem identified as 'windy eagle' in external libraries that the project relies upon. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the project version from 1.72.0 to 1.73.0. The changes are applied consistently in Src/Support/CommonProjectProperties.xml and features.json. This version bump appears to be a necessary step to mitigate a security vulnerability as noted in the description. The changes are correct and align with the purpose of the pull request. I find no issues with this update.
amanda-tarafa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit message and the PR description to include all the new features or fixes that would be included in this release. You can use #3054 both as an example and as the lower boundary to look for changes that are included in this one.
f63e8a0 to
9222446
Compare
Features: - googleapis#3064 Adds methods to load a credential by specifying the type and either file path or json string. - googleapis#3059 Supports loading scopes for impersonated credentials from new optional `scopes` field.
9222446 to
f53fc08
Compare
Required to mitigate windy eagle in dependent libraries
Features:
scopesfield.