-
Notifications
You must be signed in to change notification settings - Fork 549
feat: API regeneration: release-2025-11-24.09-02-45 #3083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request encompasses a broad API regeneration across several Google Cloud services. The primary focus is on updating API revisions, enhancing clarity in documentation, and introducing new features such as advanced filtering in Admin Reports and tag management in GKE Backup. A notable change involves the restructuring of account limit management within the Merchant API and the removal of agent-related schemas from the Workspace Events API. These updates ensure the APIs remain current and provide improved functionality and consistency. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request contains auto-generated API updates across multiple services. The changes include documentation improvements, new features like tagging in GKE Backup and new filters in Admin Reports, and API restructuring. Notably, there are significant breaking changes in the Workspace Events and Merchant Accounts APIs. While the code changes themselves appear correct, the package versioning for these libraries does not reflect the breaking changes, which is a critical issue for consumers. The package versions should be updated to follow semantic versioning, indicating a major version bump for these breaking changes.
| <PropertyGroup> | ||
| <Title>Google.Apis.Merchant.accounts_v1 Client Library</Title> | ||
| <Version>1.72.0.3971</Version> | ||
| <Version>1.73.0.3974</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update includes a breaking change by removing the Limits resource. According to semantic versioning, this should trigger a major version bump. The current change from 1.72.0.3971 to 1.73.0.3974 is only a minor version increment, which can cause unexpected build failures for consumers. Please consider incrementing the major version to reflect this breaking change.
| <PropertyGroup> | ||
| <Title>Google.Apis.WorkspaceEvents.v1 Client Library</Title> | ||
| <Version>1.72.0.3958</Version> | ||
| <Version>1.73.0.3974</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update introduces significant breaking changes by removing the V1 resource and numerous related schemas. However, the package version is only being bumped by a minor version (1.72.0.3958 to 1.73.0.3974). According to semantic versioning principles, breaking changes should result in a major version increment (e.g., to 2.0.0). Please update the version to reflect the breaking nature of these changes to avoid breaking consumers' builds unexpectedly.
Changes in this PR will be published to Nuget on the next release cycle.