Skip to content

Conversation

@amanda-tarafa
Copy link
Contributor

Changes in this PR will be published to Nuget on the next release cycle.

@amanda-tarafa amanda-tarafa requested a review from a team as a code owner November 24, 2025 09:06
@gemini-code-assist
Copy link

Summary of Changes

Hello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request encompasses a broad API regeneration across several Google Cloud services. The primary focus is on updating API revisions, enhancing clarity in documentation, and introducing new features such as advanced filtering in Admin Reports and tag management in GKE Backup. A notable change involves the restructuring of account limit management within the Merchant API and the removal of agent-related schemas from the Workspace Events API. These updates ensure the APIs remain current and provide improved functionality and consistency.

Highlights

  • API Version Updates: All affected APIs have their revision numbers updated, signaling a new release cycle and ensuring compatibility with the latest service definitions.
  • Description Clarifications: Numerous API parameter and schema descriptions, such as returnPartialSuccess, unreachable, and product resource names, have been refined for improved clarity and consistent formatting.
  • Admin Reports API Enhancements: The Admin Reports API now supports additional application names (assignments, cloud_search, tasks, data_migration, meet_hardware) and introduces a new resourceDetailsFilter for more granular querying capabilities.
  • Authorized Buyers Marketplace API Update: The Authorized Buyers Marketplace API introduces a new floorPriceCpm field within the AuctionPackage schema, providing additional pricing information.
  • GKE Backup API Tag Management: The GKE Backup API gains new getTags and setTags methods, enabling direct management of tags on backupPlans and restorePlans resources.
  • Merchant API Restructuring: The limits resource has been moved from merchantapi.accounts_v1 to merchantapi.quota_v1, indicating a significant restructuring in how account limits are managed within the Merchant API.
  • Workspace Events API Schema Removal: The v1 resource and a substantial number of associated schemas (including AgentCard, Security Schemes, and related components) have been removed from the Workspace Events API, streamlining its definition.
  • Client Library Version Bumps: All generated client libraries have received version updates, with Google.Apis and Google.Apis.Auth packages now at version 1.73.0.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request contains auto-generated API updates across multiple services. The changes include documentation improvements, new features like tagging in GKE Backup and new filters in Admin Reports, and API restructuring. Notably, there are significant breaking changes in the Workspace Events and Merchant Accounts APIs. While the code changes themselves appear correct, the package versioning for these libraries does not reflect the breaking changes, which is a critical issue for consumers. The package versions should be updated to follow semantic versioning, indicating a major version bump for these breaking changes.

<PropertyGroup>
<Title>Google.Apis.Merchant.accounts_v1 Client Library</Title>
<Version>1.72.0.3971</Version>
<Version>1.73.0.3974</Version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update includes a breaking change by removing the Limits resource. According to semantic versioning, this should trigger a major version bump. The current change from 1.72.0.3971 to 1.73.0.3974 is only a minor version increment, which can cause unexpected build failures for consumers. Please consider incrementing the major version to reflect this breaking change.

<PropertyGroup>
<Title>Google.Apis.WorkspaceEvents.v1 Client Library</Title>
<Version>1.72.0.3958</Version>
<Version>1.73.0.3974</Version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update introduces significant breaking changes by removing the V1 resource and numerous related schemas. However, the package version is only being bumped by a minor version (1.72.0.3958 to 1.73.0.3974). According to semantic versioning principles, breaking changes should result in a major version increment (e.g., to 2.0.0). Please update the version to reflect the breaking nature of these changes to avoid breaking consumers' builds unexpectedly.

@jskeet jskeet merged commit d81ece7 into main Nov 24, 2025
5 checks passed
@jskeet jskeet deleted the release-2025-11-24.09-02-45 branch November 24, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants