-
Notifications
You must be signed in to change notification settings - Fork 549
feat: API regeneration: release-2025-11-26.09-02-51 #3084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine regeneration of several Google API client libraries, updating their underlying API definitions. The changes introduce new data structures and fields, expand authorization scopes for certain services, and ensure that the client libraries are up-to-date with the latest API specifications. These updates are essential for maintaining compatibility and providing access to new features across the integrated services. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated API regeneration, introducing new features and updating dependencies for several Google API client libraries. The changes are consistent across the discovery documents and the generated C# code.
My main feedback is regarding the youtubereporting.v1 API. A new field downloadExternalReadToken has been added with a non-descriptive 'gdata' description. This affects both the API's JSON discovery file and the generated C# client library, hindering usability and maintainability. I've left specific comments suggesting that this be improved in the source for better clarity for API consumers and developers.
| "type": "string" | ||
| }, | ||
| "downloadExternalReadToken": { | ||
| "description": "gdata", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [Newtonsoft.Json.JsonPropertyAttribute("blobId")] | ||
| public virtual string BlobId { get; set; } | ||
|
|
||
| /// <summary>gdata</summary> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The XML comment 'gdata' is not descriptive and doesn't help developers understand the purpose of the DownloadExternalReadToken property. Since this code is generated, the source discovery document should be updated with a more meaningful description. A good summary would clarify what this token is and how it's used.
Changes in this PR will be published to Nuget on the next release cycle.