-
Notifications
You must be signed in to change notification settings - Fork 549
feat: API regeneration: release-2025-12-01.09-02-31 #3085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @amanda-tarafa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs an API regeneration across multiple Google API client libraries. The primary goal is to synchronize the client libraries with the latest upstream API definitions, introducing new features, correcting existing descriptions, and expanding supported functionalities. These updates ensure that developers using these libraries have access to the most current API capabilities and improved data handling mechanisms. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated API regeneration. It introduces several new features across different services, such as guest user creation in the Admin SDK Directory API, new application names for activity reports in the Reports API, and a new batchGetStats endpoint for videos in the YouTube API. It also includes a helpful documentation fix in the Cloud Identity API. My review identified two minor inconsistencies in the new YouTube API definition where parameters are described as 'Required' in their descriptions but are not marked as such in the API schema. These have been flagged for correction to avoid confusion for developers.
| "type": "string" | ||
| }, | ||
| "part": { | ||
| "description": "Required. The `**part**` parameter specifies a comma-separated list of one or more `videoStat` resource properties that the API response will include. If the parameter identifies a property that contains child properties, the child properties will be included in the response. For example, in a `videoStat` resource, the `statistics` property contains `view_count` and `like_count`. As such, if you set `**part=snippet**`, the API response will contain all of those properties.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "type": "string" | ||
| }, | ||
| "videoIds": { | ||
| "description": "Required. Return videos with the given ids.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description for the videoIds parameter states that it is "Required". However, the schema for this parameter is missing the "required": true property. This inconsistency can be misleading for developers using the API. Please add "required": true to the parameter definition if it is indeed mandatory.
Changes in this PR will be published to Nuget on the next release cycle.