feat: API regeneration: release-2026-03-23.08-02-43#3141
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the Google APIs .NET Client Library through API regeneration. It incorporates the latest changes in various Google services, including updates to existing discovery JSON files and the addition of a new API, Agent Registry. These updates ensure that the library remains current with the latest API definitions and features. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request contains a large number of automated updates for API discovery documents, reflecting new features, deprecations, and documentation improvements across many Google Cloud services. My review focused on the consistency and clarity of these changes. Overall, the updates are beneficial, enhancing the accuracy and usability of the API definitions. I've identified a few minor areas where descriptions could be clearer or more consistent to prevent potential confusion for developers. These are detailed in the specific comments.
| "type": "string" | ||
| }, | ||
| "serviceId": { | ||
| "description": "Required. The ID to use for the service, which will become the final component of the service's resource name. This value should be 4-63 characters, and valid characters are `/a-z-/`.", |
There was a problem hiding this comment.
The description for serviceId states that valid characters are /a-z-/. This is ambiguous. It's unclear if slashes are permitted or are just delimiters in the description. Typically, resource IDs follow a pattern like [a-z]([a-z0-9-]{0,61}[a-z0-9])?. Please clarify the set of valid characters to avoid confusion for developers.
| ], | ||
| "parameters": { | ||
| "filter": { | ||
| "description": "Optional. Filter for the transfer resources. Currently supported filters include: * Resource name: `name` - Wildcard supported * Resource type: `type` * Resource destination: `destination` * Latest resource state: `latest_status_detail.state` * Last update time: `update_time` - RFC-3339 format * Parent table name: `hierarchy_detail.partition_detail.table` Multiple filters can be applied using the `AND/OR` operator. Examples: * `name=\"*123\" AND (type=\"TABLE\" OR latest_status_detail.state=\"SUCCEEDED\")` * `update_time >= \"2012-04-21T11:30:00-04:00` * `hierarchy_detail.partition_detail.table = \"table1\"`", |
There was a problem hiding this comment.
There appears to be a typo in an example for the filter parameter. The example update_time >= "2012-04-21T11:30:00-04:00 is missing a closing double quote. It should likely be update_time >= "2012-04-21T11:30:00-04:00".
| "id": "AlertPolicyCheck", | ||
| "properties": { | ||
| "alertPolicies": { | ||
| "description": "Required. The Cloud Monitoring Alert Policies to check for active alerts. Format is `projects/{project}/alertPolicies/{alert_policy}`.", |
There was a problem hiding this comment.
The format description for alertPolicies is projects/{project}/alertPolicies/{alert_policy}. However, the corresponding status field AlertPolicyCheckStatus.alertPolicies (line 2510) uses the format projects/{project}/locations/{location}/alertPolicies/{alertPolicy}, which includes the location. Please ensure the format is consistent and correct. If the location is required, it should be included in this description as well.
| "enumDescriptions": [ | ||
| "", | ||
| "", | ||
| "", | ||
| "", | ||
| "", | ||
| "", | ||
| "" | ||
| ], |
There was a problem hiding this comment.
The enumDescriptions for generatorType are all empty strings. Please provide meaningful descriptions for each enum value (FREE_FORM, AGENT_COACHING, etc.) to clarify their purpose.
| "enumDescriptions": [ | ||
| "", | ||
| "", | ||
| "", | ||
| "", | ||
| "", | ||
| "" | ||
| ], |
There was a problem hiding this comment.
The enumDescriptions for endState in GoogleCloudDialogflowCxV3TraceBlock are all empty strings. Please add descriptions for each state (OUTPUT_STATE_OK, OUTPUT_STATE_CANCELLED, etc.) to explain what they represent.
2 participants
Changes in this PR will be published to Nuget on the next release cycle.