Skip to content

Conversation

@sofisl
Copy link
Contributor

@sofisl sofisl commented May 5, 2025

This PR:

  1. Updates the post-processor image to latest
  2. Updates tests to Node 18
  3. Importantly: updates the generator to delete any libraries that are no longer maintained. See https://chat.google.com/room/AAAA3k1_t2c/jekVKt62rc0
  4. Updates all dependencies to their latest version, including gaxios and nodejs-googleapis-common (see feat!: Support AIP-193 for GaxiosError gaxios#699, fix: Ensure Marshalled GaxiosResponse has all properties nodejs-googleapis-common#605), which were caught in these tests
  5. Updates all instances of GaxiosPromise to Promise (chore!: bump deps nodejs-googleapis-common#591)
  6. Reruns the generator to update all of the APIs with the new syntax.

BEGIN_COMMIT_OVERRIDE
feat!: upgrade to node 18
END_COMMIT_OVERRIDE

@sofisl sofisl requested a review from a team as a code owner May 5, 2025 23:11
@sofisl sofisl changed the title Upgrade to node18 chore!: upgrade to node 18 May 5, 2025
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label May 5, 2025
@generated-files-bot
Copy link

generated-files-bot bot commented May 5, 2025

Warning: This pull request is touching the following templated files:

  • .kokoro/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/samples-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/system-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node18/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs-devsite.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/release/docs.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/samples-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/system-test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.bat - .kokoro files are templated and should be updated in synthtool
  • .kokoro/test.sh - .kokoro files are templated and should be updated in synthtool
  • .kokoro/trampoline_v2.sh - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels May 5, 2025
@sofisl
Copy link
Contributor Author

sofisl commented May 7, 2025

The last fields aren't updating in the generator because they're not present in index.json. Looking.

@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2025
d-goog
d-goog previously approved these changes May 28, 2025
@sofisl sofisl force-pushed the upgradeToNode18 branch from 4908598 to d5da57a Compare May 28, 2025 22:28
@sofisl sofisl merged commit 682fbb8 into main May 28, 2025
16 of 17 checks passed
@sofisl sofisl deleted the upgradeToNode18 branch May 28, 2025 22:55
@sofisl sofisl added the release-please:force-run To run release-please label May 28, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label May 28, 2025
@sofisl sofisl added the release-please:force-run To run release-please label May 28, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label May 28, 2025
@sofisl sofisl added the release-please:force-run To run release-please label May 28, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label May 28, 2025
@sofisl sofisl added the release-please:force-run To run release-please label May 28, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label May 28, 2025
@sofisl sofisl added the release-please:force-run To run release-please label May 29, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label May 29, 2025
@sofisl sofisl changed the title chore!: upgrade to node 18 feat!: upgrade to node 18 May 29, 2025
@sofisl sofisl added the release-please:force-run To run release-please label May 29, 2025
@release-please release-please bot removed the release-please:force-run To run release-please label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants