Skip to content

chore: remove dependency on UUID #3678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 16, 2025
Merged

chore: remove dependency on UUID #3678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6d0cde4
chore: remove dependency on UUID
sofisl Jun 6, 2025
05bc33f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jun 6, 2025
e810901
chore: remove comma
sofisl Jun 10, 2025
83dfd51
Merge branch 'removeUUID' of github.com:googleapis/google-api-nodejs-…
sofisl Jun 10, 2025
4899f9e
chore: update googleapis common
sofisl Jun 16, 2025
b04fc44
Merge branch 'main' into removeUUID
sofisl Jun 16, 2025
7eb3111
remove uuid
sofisl Jun 16, 2025
26c3a67
Merge branch 'removeUUID' of github.com:googleapis/google-api-nodejs-…
sofisl Jun 16, 2025
f345ec6
remove extra call to uuid.random()
sofisl Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"js-yaml": "^4.1.0"
},
"devDependencies": {
"@octokit/rest": "^21.0.0",
Copy link
Contributor Author

@sofisl sofisl Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are autogenerated changes

"@octokit/rest": "^19.0.0",
"mocha": "^10.0.0",
"sinon": "^20.0.0"
"sinon": "^18.0.0"
}
}
2 changes: 1 addition & 1 deletion .github/workflows/issues-no-repro.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
pull-requests: write
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Copy link
Contributor Author

@sofisl sofisl Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are autogenerated changes

- uses: actions/setup-node@v3
with:
node-version: 18
- run: npm install
Expand Down
7 changes: 3 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@
"client library"
],
"dependencies": {
"google-auth-library": "^10.0.0-rc.1",
"googleapis-common": "^8.0.2-rc.0"
"google-auth-library": "^10.1.0",
"googleapis-common": "^8.0.0"
},
"devDependencies": {
"@types/execa": "^2.0.2",
Expand All @@ -73,11 +73,10 @@
"@types/url-template": "^2.0.28",
"@types/yargs-parser": "^21.0.3",
"c8": "^10.1.3",
"cheerio": "^1.0.0",
"codecov": "^3.8.3",
"cross-env": "^7.0.3",
"execa": "^5.0.0",
"gaxios": "^7.0.0-rc.5",
"gaxios": "^7.1.0",
"gts": "^6.0.2",
"js-green-licenses": "^4.0.0",
"jsdoc": "^4.0.4",
Expand Down
5 changes: 3 additions & 2 deletions samples/drive/download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@
const {google} = require('googleapis');
const fs = require('fs');
const os = require('os');
const uuid = require('uuid');
const path = require('path');
const {authenticate} = require('@google-cloud/local-auth');
const crypto = require('crypto');
const uuid = crypto.randomUUID();

const drive = google.drive('v3');

Expand All @@ -45,7 +46,7 @@ async function runSample(fileId) {
.get({fileId, alt: 'media'}, {responseType: 'stream'})
.then(res => {
return new Promise((resolve, reject) => {
const filePath = path.join(os.tmpdir(), uuid.v4());
const filePath = path.join(os.tmpdir(), uuid);
console.log(`writing to ${filePath}`);
const dest = fs.createWriteStream(filePath);
let progress = 0;
Expand Down
3 changes: 1 addition & 2 deletions samples/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
"googleapis-common": "^8.0.2-rc.0",
"nconf": "^0.13.0",
"open": "^8.0.0",
"server-destroy": "^1.0.1",
"uuid": "^10.0.0"
"server-destroy": "^1.0.1"
},
"devDependencies": {
"chai": "^4.2.0",
Expand Down
4 changes: 2 additions & 2 deletions test/test.options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
import {URL} from 'url';
import {GoogleApis} from '../src';
import {Utils} from './utils';
import {GoogleAuth} from 'google-auth-library';
import {AuthClient, GoogleAuth} from 'google-auth-library';
import * as sinon from 'sinon';
import {GaxiosResponse} from 'gaxios';
import {JSONClient} from 'google-auth-library/build/src/auth/googleauth';

Check warning on line 23 in test/test.options.ts

View workflow job for this annotation

GitHub Actions / lint 

'JSONClient' is defined but never used

function createNock(path?: string) {
const p = path || '/drive/v2/files/woot';
Expand Down Expand Up @@ -309,7 +309,7 @@
const auth = new GoogleAuth();
const stub = sandbox.stub(auth, 'request').resolves({} as GaxiosResponse);
// global options
google.options({auth: auth as GoogleAuth<JSONClient>});
google.options({auth: auth as GoogleAuth<AuthClient>});
// per-API options
const drive = google.drive({version: 'v3', auth});
// per-call options
Expand Down
Loading