-
Notifications
You must be signed in to change notification settings - Fork 346
fix: Python 3.8 support #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+89
−7
Merged
fix: Python 3.8 support #1918
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7d3d877
import sequence from typing
daniel-sanche 1e98bc1
add 3.7 and 3.8 to unit tests
daniel-sanche 0d41115
added nox session
daniel-sanche 4f4db7b
added github actions
daniel-sanche 31ba7ef
added annotations
daniel-sanche 31c4346
added extra annotations import
daniel-sanche 1aa5bb7
support AsyncMock on 3.7
daniel-sanche 8a1444a
adding mock to constraints file
daniel-sanche 649855a
add mock to testing extras
daniel-sanche 8a082c9
remove 3.7 from tests
daniel-sanche 3322dfe
revert 3.7 changes
daniel-sanche 1211004
fixed lint
daniel-sanche 5b78fa3
fixed lint
daniel-sanche 9dce704
Update .github/workflows/unittest.yml
daniel-sanche a48ccda
add copyright header
daniel-sanche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| name: unittest | ||
daniel-sanche marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| jobs: | ||
| unit: | ||
| runs-on: ubuntu-22.04 | ||
| strategy: | ||
| matrix: | ||
| python: ['3.8'] | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python }} | ||
| - name: Install nox | ||
| run: | | ||
| python -m pip install --upgrade setuptools pip wheel | ||
| python -m pip install nox | ||
| - name: Run unit tests | ||
| env: | ||
| COVERAGE_FILE: .coverage-${{ matrix.python }} | ||
| run: | | ||
| nox -s unit-${{ matrix.python }} | ||
| - name: Upload coverage results | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: coverage-artifact-${{ matrix.python }} | ||
| path: .coverage-${{ matrix.python }} | ||
| include-hidden-files: true | ||
|
|
||
| cover: | ||
| runs-on: ubuntu-latest | ||
| needs: | ||
| - unit | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: "3.13" | ||
| - name: Install coverage | ||
| run: | | ||
| python -m pip install --upgrade setuptools pip wheel | ||
| python -m pip install coverage | ||
| - name: Download coverage results | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| path: .coverage-results/ | ||
| - name: Report coverage results | ||
| run: | | ||
| find .coverage-results -type f -name '*.zip' -exec unzip {} \; | ||
| coverage combine .coverage-results/**/.coverage* | ||
| coverage report --show-missing --fail-under=99 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.