-
Notifications
You must be signed in to change notification settings - Fork 346
fix: Python 3.7 support #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Python 3.7 support #1920
Conversation
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on restoring and enhancing compatibility with Python 3.7 and 3.8. It addresses the absence of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Python 3.7 by making several compatibility adjustments. The main changes include updating type hints for compatibility with Python versions older than 3.9, conditionally importing AsyncMock from the mock backport library for Python < 3.8, and updating the test configuration to include Python 3.7 and 3.8. The changes are well-implemented and correctly address the version compatibility issues. I have one suggestion regarding the noxfile.py configuration to ensure the new Python versions are included in the default test run.
noxfile.py
Outdated
| @@ -44,8 +51,6 @@ | |||
| "lint", | |||
| "blacken", | |||
| "mypy", | |||
| # TODO(https://github.com/googleapis/google-auth-library-python/issues/1787): | |||
| # Remove or restore testing for Python 3.7/3.8 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Decided to remove 3.7 support instead: #1919 |
Added back 3.7 unit tests, and fixed up test code to pass on 3.7