Skip to content

chore: remove unused pugixml dependency #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotthart merged 1 commit into from
Feb 6, 2025
Merged

chore: remove unused pugixml dependency #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions bazel/development2.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@

"""Load dependencies needed for google-cloud-cpp development / Phase 2."""

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")

def gl_cpp_development2(name = None):
"""Loads dependencies needed to develop the google-cloud-cpp libraries.

Expand All @@ -27,16 +24,3 @@ def gl_cpp_development2(name = None):
name: Unused. It is conventional to provide a `name` argument to all
workspace functions.
"""

# An XML parser and generator, this is only used in //docfx.
# This is an internal tool used to generate the reference documentation.
maybe(
http_archive,
name = "com_github_zeux_pugixml",
urls = [
"https://github.com/zeux/pugixml/archive/v1.14.tar.gz",
],
sha256 = "610f98375424b5614754a6f34a491adbddaaec074e9044577d965160ec103d2e",
strip_prefix = "pugixml-1.14",
build_file = Label("//bazel:pugixml.BUILD"),
)
30 changes: 0 additions & 30 deletions bazel/pugixml.BUILD
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions ci/cloudbuild/dockerfiles/fedora-latest-cmake-gcc.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ RUN dnf makecache && dnf install -y java-latest-openjdk
RUN dnf makecache && dnf install -y "dnf-command(debuginfo-install)"
RUN dnf makecache && dnf debuginfo-install -y libstdc++

# These are used by the docfx tool.
RUN dnf makecache && dnf install -y pugixml-devel yaml-cpp-devel

# Sets root's password to the empty string to enable users to get a root shell
# inside the container with `su -` and no password. Sudo would not work because
# we run these containers as the invoking user's uid, which does not exist in
Expand Down
3 changes: 0 additions & 3 deletions ci/cloudbuild/dockerfiles/fedora-latest-cmake.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ RUN dnf makecache && dnf install -y java-latest-openjdk
RUN dnf makecache && dnf install -y "dnf-command(debuginfo-install)"
RUN dnf makecache && dnf debuginfo-install -y libstdc++

# These are used by the docfx tool.
RUN dnf makecache && dnf install -y pugixml-devel yaml-cpp-devel

# Sets root's password to the empty string to enable users to get a root shell
# inside the container with `su -` and no password. Sudo would not work because
# we run these containers as the invoking user's uid, which does not exist in
Expand Down
Loading