impl: Add TracingConnection decorator #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolduc
reviewed
Feb 3, 2025
Member
dbolduc
left a comment
dbolduc
left a comment
There was a problem hiding this comment.
The code all looks good. There are two things to do.
- change to use
google-cloud-cpp::mocks/@google_cloud_cpp//:mocksinstead of copying over those files. Feel free to do this in a follow up PR. - Add an actionable suggestion to the CMake error message
Comment for next time: This PR does too many independent things at once. Try to break PRs up into smaller pieces. Like:
- PR to add CMake option
- PR to copy over testing_util build files
- PR adding tracing connection impl
- PR using the tracing connection wrapper in MakeConnection
- PR for bazel OTel components
dbolduc
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TracingConnection decorator except
ReadArrow.#53