impl(generator): generate ud samples (#15657)

Author: scotthart

bazel/gapic.bzl

@@ -82,6 +82,7 @@ def cc_gapic_library(name, service_dirs = [], googleapis_deps = [], additional_d
         tags = ["integration-test"],
         deps = [
             "//:" + name,
+            "//:universe_domain",
             "//google/cloud/testing_util:google_cloud_cpp_testing_private",
         ],
     ) for sample in native.glob([d + "samples/*_samples.cc" for d in service_dirs])]

ci/abi-dumps/google_cloud_cpp_universe_domain.expected.abi.dump.gz

@@ -31,10 +31,10 @@ if [ "${GOOGLE_CLOUD_CPP_CHECK_API:-}" ]; then
   readonly ENABLED_FEATURES="${GOOGLE_CLOUD_CPP_CHECK_API}"
   IFS=',' read -ra library_list <<<"${GOOGLE_CLOUD_CPP_CHECK_API}"
 else
-  readonly ENABLED_FEATURES="__ga_libraries__,opentelemetry"
+  readonly ENABLED_FEATURES="__ga_libraries__,opentelemetry,universe_domain"
   mapfile -t library_list < <(cmake -P cmake/print-ga-libraries.cmake 2>&1)
   # These libraries are not "features", but they are part of the public API
-  library_list+=("common" "grpc_utils")
+  library_list+=("common" "grpc_utils" "universe_domain")
   # This is a GA library, not included in __ga_libraries__
   library_list+=("opentelemetry")
 fi
@@ -67,7 +67,7 @@ function check_abi() {
 
   local shortlib="${library#google_cloud_cpp_}"
   local public_headers="${prefix}/include/google/cloud/${shortlib}"
-  if [[ "${shortlib}" == "common" || "${shortlib}" == "grpc_utils" || "${shortlib}" == "oauth2" ]]; then
+  if [[ "${shortlib}" == "common" || "${shortlib}" == "grpc_utils" || "${shortlib}" == "universe_domain" || "${shortlib}" == "oauth2" ]]; then
     # These are special and share their header location.
     public_headers="${prefix}/include/google/cloud"
   elif [[ "${shortlib}" == "storage_grpc" ]]; then

ci/cloudbuild/builds/check-api.sh

@@ -164,6 +164,7 @@ expected_dirs+=(
   ./lib64/cmake/google_cloud_cpp_rest_protobuf_internal
   ./lib64/cmake/google_cloud_cpp_storage_grpc
   ./lib64/cmake/google_cloud_cpp_storage_grpc_mocks
+  ./lib64/cmake/google_cloud_cpp_universe_domain
   ./lib64/pkgconfig
 )
 

ci/cloudbuild/builds/cmake-install.sh

@@ -42,6 +42,8 @@ function features::always_build() {
     opentelemetry
     # Enable storage_grpc in most builds.
     storage_grpc
+    # Samples require universe domain support.
+    universe_domain
   )
   printf "%s\n" "${list[@]}" | sort -u
 }
@@ -63,6 +65,7 @@ function features::_internal_extra() {
   local list=(
     experimental-bigquery_rest
     opentelemetry
+    universe_domain
   )
   printf "%s\n" "${list[@]}"
 }

ci/cloudbuild/builds/lib/features.sh

@@ -35,7 +35,7 @@ elif [[ "${LIBRARIES}" == "all_bar_compute" ]]; then
   ENABLED_FEATURES="${ENABLED_FEATURES},-compute"
 else
   mapfile -t FEATURE_LIST < <(printf '%s' "${LIBRARIES}")
-  ENABLED_FEATURES="compute"
+  ENABLED_FEATURES="compute,universe_domain"
 fi
 
 doc_args=(

ci/cloudbuild/builds/publish-docs.sh

@@ -36,11 +36,13 @@ readonly DEFAULT_SHARD=(
   bigtable
   spanner
   logging
+  universe_domain
 )
 
 readonly BIGQUERY_SHARD=(
   bigquery
   experimental-bigquery_rest
+  universe_domain
 )
 
 readonly PUBSUB_SHARD=(
@@ -51,6 +53,7 @@ readonly PUBSUB_SHARD=(
   # IAM is included because it has hand-crafted tests and/or examples and is
   # required by Pub/Sub
   iam
+  universe_domain
 )
 
 readonly STORAGE_SHARD=(
@@ -66,6 +69,7 @@ readonly STORAGE_SHARD=(
 readonly TOOLS_SHARD=(
   generator
   docfx
+  universe_domain
 )
 
 function shard::cmake_features() {

ci/lib/shard.sh

@@ -132,12 +132,16 @@ function (google_cloud_cpp_add_samples_relative library path)
         google_cloud_cpp_add_executable(target "${library}" "${source}")
         if (TARGET google-cloud-cpp::${library})
             target_link_libraries(
-                "${target}" PRIVATE google-cloud-cpp::${library}
-                                    google_cloud_cpp_testing)
+                "${target}"
+                PRIVATE google-cloud-cpp::${library}
+                        google-cloud-cpp::universe_domain
+                        google_cloud_cpp_testing)
         elseif (TARGET google-cloud-cpp::experimental-${library})
             target_link_libraries(
-                "${target}" PRIVATE google-cloud-cpp::experimental-${library}
-                                    google_cloud_cpp_testing)
+                "${target}"
+                PRIVATE google-cloud-cpp::experimental-${library}
+                        google-cloud-cpp::universe_domain
+                        google_cloud_cpp_testing)
         endif ()
         google_cloud_cpp_add_common_options("${target}")
         add_test(NAME "${target}" COMMAND "${target}")

cmake/GoogleCloudCppCommon.cmake

@@ -145,6 +145,7 @@ filegroup(
     tags = ["integration-test"],
     deps = [
         ":google_cloud_cpp_generator_golden",
+        "//:universe_domain",
         "//google/cloud/testing_util:google_cloud_cpp_testing_private",
     ],
 ) for sample in glob(["golden/v1/samples/*.cc"])]

generator/integration_tests/BUILD.bazel

@@ -131,7 +131,9 @@ foreach (fname IN LISTS samples_cc)
     target_link_libraries(
         ${target}
         PRIVATE google_cloud_cpp_generator_golden_testing
-                google_cloud_cpp_generator_golden google_cloud_cpp_testing
+                google_cloud_cpp_generator_golden
+                google_cloud_cpp_universe_domain
+                google_cloud_cpp_testing
                 google_cloud_cpp_testing_grpc)
     google_cloud_cpp_add_common_options(${target})
     add_test(NAME ${target} COMMAND ${target})