don't run ListBucketsPartialSuccess in production

Author: bajajneha27

google/cloud/storage/client.h

@@ -389,7 +389,7 @@ class Client {
    * This is a read-only operation and is always idempotent.
    *
    * @par Example
-   * @snippet storage_bucket_samples.cc list buckets partial result
+   * @snippet storage_bucket_samples.cc list buckets partial success
    */
   template <typename... Options>
   ListBucketsExtendedReader ListBucketsExtended(Options&&... options) {

google/cloud/storage/examples/storage_bucket_samples.cc

@@ -49,9 +49,10 @@ void ListBuckets(google::cloud::storage::Client client,
   (std::move(client));
 }
 
-void ListBucketsExtended(google::cloud::storage::Client client,
-                         std::vector<std::string> const& /*argv*/) {
-  //! [list buckets partial result] [START storage_list_buckets_partial_success]
+void ListBucketsPartialSuccess(google::cloud::storage::Client client,
+                               std::vector<std::string> const& /*argv*/) {
+  //! [list buckets partial success] [START
+  //! storage_list_buckets_partial_success]
   namespace gcs = ::google::cloud::storage;
   using ::google::cloud::StatusOr;
   [](gcs::Client client) {
@@ -73,7 +74,7 @@ void ListBucketsExtended(google::cloud::storage::Client client,
       std::cout << "No buckets in default project\n";
     }
   }
-  //! [list buckets partial result] [END storage_list_buckets_partial_success]
+  //! [list buckets partial success] [END storage_list_buckets_partial_success]
   (std::move(client));
 }
 
@@ -712,8 +713,8 @@ void RunAll(std::vector<std::string> const& argv) {
   std::cout << "\nRunning ListBuckets() example" << std::endl;
   ListBuckets(client, {});
 
-  std::cout << "\nRunning ListBucketsExtended() example" << std::endl;
-  ListBucketsExtended(client, {});
+  std::cout << "\nRunning ListBucketsPartialSuccess() example" << std::endl;
+  ListBucketsPartialSuccess(client, {});
 
   std::cout << "\nRunning CreateBucket() example" << std::endl;
   CreateBucket(client, {bucket_name});
@@ -758,8 +759,8 @@ int main(int argc, char* argv[]) {
 
   examples::Example example({
       examples::CreateCommandEntry("list-buckets", {}, ListBuckets),
-      examples::CreateCommandEntry("list-buckets-extended", {},
-                                   ListBucketsExtended),
+      examples::CreateCommandEntry("list-buckets-partial-success", {},
+                                   ListBucketsPartialSuccess),
       examples::CreateCommandEntry("list-buckets-for-project", {"<project-id>"},
                                    ListBucketsForProject),
       make_entry("create-bucket", {}, CreateBucket),

google/cloud/storage/internal/connection_impl_bucket_test.cc

@@ -74,7 +74,7 @@ TEST(StorageConnectionImpl, ListBucketsPartialResult) {
                    ListBucketsRequest const& r) {
         EXPECT_TRUE(r.return_partial_success());
         ListBucketsResponse response;
-        response.items.emplace_back(BucketMetadata{});
+        response.items.emplace_back(BucketMetadata{}.set_name("bucket2"));
         response.unreachable.emplace_back("projects/_/buckets/bucket1");
         return response;
       });

google/cloud/storage/tests/bucket_integration_test.cc

@@ -684,6 +684,8 @@ TEST_F(BucketIntegrationTest, ListFailure) {
 }
 
 TEST_F(BucketIntegrationTest, ListPartialSuccess) {
+  // This test requires the emulator to simulate unreachable buckets.
+  if (!UsingEmulator()) GTEST_SKIP();
   auto client = MakeIntegrationTestClient();
   std::string bucket_name = MakeRandomBucketName();
   std::string unreachable_bucket_name =