Skip to content

Commit fe47f12

Browse files
authored
Merge branch 'main' into conformance-tests
2 parents 70e0c94 + 41ea3fc commit fe47f12

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

google/cloud/bigtable/ci/run_conformance_tests_proxy_bazel.sh

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ exit_status=$?
5151
# CloseClient
5252
go test -v \
5353
-run "TestExecuteQuery|TestExecuteQuery_PlanRefresh$|TestExecuteQuery_PlanRefresh_WithMetadataChange|TestExecuteQuery_PlanRefresh_Retries|TestExecuteQuery_FailsOnSuccesfulStreamWithNoToken" \
54-
-skip "CloseClient|FailsOnEmptyMetadata|FailsOnExecuteQueryMetadata|FailsOnInvalidType|FailsOnNotEnoughData|FailsOnNotEnoughDataWithCompleteRows|FailsOnSuccesfulStreamWithNoToken|FailsOnTypeMismatch|FailsOnTypeMismatchWithinMap|FailsOnTypeMismatchWithinArray|FailsOnTypeMismatchWithinStruct|FailsOnStructMissingField|TestExecuteQuery_PlanRefresh_AfterResumeTokenCausesError|TestExecuteQuery_RetryTest_WithPlanRefresh|TestExecuteQuery_PlanRefresh_RespectsDeadline|TestExecuteQuery_PlanRefresh_RecoversAfterPermanentError" \
54+
-skip "CloseClient|FailsOnEmptyMetadata|FailsOnExecuteQueryMetadata|FailsOnInvalidType|FailsOnTypeMismatch|FailsOnTypeMismatchWithinMap|FailsOnTypeMismatchWithinArray|FailsOnTypeMismatchWithinStruct|FailsOnStructMissingField|TestExecuteQuery_PlanRefresh_AfterResumeTokenCausesError|TestExecuteQuery_RetryTest_WithPlanRefresh|TestExecuteQuery_PlanRefresh_RespectsDeadline|TestExecuteQuery_PlanRefresh_RecoversAfterPermanentError" \
5555
-proxy_addr=:9999
5656
exit_status=$?
5757

@@ -65,12 +65,6 @@ exit_status=$?
6565
# -proxy_addr=:9999
6666
#exit_status=$?
6767

68-
# Stream reading tests b/461232110
69-
#go test -v \
70-
# -run "FailsOnNotEnoughData|FailsOnNotEnoughDataWithCompleteRows" \
71-
# -proxy_addr=:9999
72-
#exit_status=$?
73-
7468
# Response/Metadata mismatches b/461233335
7569
#go test -v \
7670
# -run "FailsOnTypeMismatch|FailsOnTypeMismatchWithinMap|FailsOnTypeMismatchWithinArray|FailsOnTypeMismatchWithinStruct|FailsOnStructMissingField" \
@@ -79,7 +73,7 @@ exit_status=$?
7973

8074
# QueryPlan refresh tests b/461233613
8175
#go test -v \
82-
# -run "RetryTest_WithPlanRefresh|PlanRefresh" \
76+
# -run "RetryTest_WithPlanRefresh|PlanRefresh|PlanRefresh_RecoversAfterPermanentError" \
8377
# -proxy_addr=:9999
8478
#exit_status=$?
8579

google/cloud/bigtable/internal/partial_result_set_source.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,10 @@ Status PartialResultSetSource::BufferProtoRows() {
215215
GCP_ERROR_INFO());
216216
}
217217
if (proto_values.size() % columns_size != 0) {
218+
state_ = State::kFinished;
218219
return internal::InternalError(
219220
"The number of values in ProtoRows is not a multiple of the "
220-
"number of columns in the schema.",
221+
"number of columns in the schema or received incomplete row",
221222
GCP_ERROR_INFO());
222223
}
223224

0 commit comments

Comments
 (0)