ci: add SA to SA impersonation integration tests for universe domain #14862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuiy0006
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14862 +/- ##
=======================================
Coverage 93.00% 93.00%
=======================================
Files 2351 2351
Lines 209479 209479
=======================================
+ Hits 194828 194831 +3
+ Misses 14651 14648 -3 ☔ View full report in Codecov by Sentry. |
cuiy0006
commented
Nov 27, 2024
dbolduc
approved these changes
Dec 2, 2024
Member
dbolduc
left a comment
dbolduc
left a comment
There was a problem hiding this comment.
The missing license is the only important thing we need to fix.
google/cloud/universe_domain/integration_tests/impersonation_tests.cc
Outdated
Show resolved
Hide resolved
google/cloud/universe_domain/integration_tests/impersonation_tests.cc
Outdated
Show resolved
Hide resolved
google/cloud/universe_domain/integration_tests/impersonation_tests.cc
Outdated
Show resolved
Hide resolved
google/cloud/universe_domain/integration_tests/impersonation_tests.cc
Outdated
Show resolved
Hide resolved
cuiy0006
deleted the
universe-domain-add-impersonation-integration-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds service account to service account impersonation tests.
In the following PRs, the tests will be added:
This change is