Skip to content

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Dec 3, 2024

BCR only provides grpc v1.68.0


This change is Reviewable

@scotthart scotthart requested a review from a team as a code owner December 3, 2024 21:36
bazel_dep(name = "protobuf", version = "29.0", repo_name = "com_google_protobuf")
bazel_dep(name = "boringssl", version = "0.0.0-20230215-5c22014")
bazel_dep(name = "grpc", version = "1.66.0", repo_name = "com_github_grpc_grpc")
bazel_dep(name = "grpc", version = "1.68.0", repo_name = "com_github_grpc_grpc")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we ignore the patch version in this and previous PRs like https://github.com/googleapis/google-cloud-cpp/pull/14585/files. Why do we ignore it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're limited by what BCR provides: https://registry.bazel.build/modules/grpc

Copy link
Member Author

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion (waiting on @cuiy0006)

bazel_dep(name = "protobuf", version = "29.0", repo_name = "com_google_protobuf")
bazel_dep(name = "boringssl", version = "0.0.0-20230215-5c22014")
bazel_dep(name = "grpc", version = "1.66.0", repo_name = "com_github_grpc_grpc")
bazel_dep(name = "grpc", version = "1.68.0", repo_name = "com_github_grpc_grpc")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're limited by what BCR provides: https://registry.bazel.build/modules/grpc

@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.00%. Comparing base (6026c70) to head (5f5408a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14869   +/-   ##
=======================================
  Coverage   93.00%   93.00%           
=======================================
  Files        2351     2351           
  Lines      209479   209479           
=======================================
+ Hits       194831   194832    +1     
+ Misses      14648    14647    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scotthart scotthart merged commit 53a0f97 into googleapis:main Dec 4, 2024
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants