Skip to content

Conversation

@cuiy0006
Copy link
Contributor

@cuiy0006 cuiy0006 commented Dec 4, 2024

  1. Update googleapis SHA based on COMMIT=d675ec222c431e3346ba8aaf0027392fe8b3d90c and COMMIT_DATE=2024-11-28

  2. Manually add external dependency google/iam/v1/resource_policy_member.proto.

  3. Remove some substitutions in generator/internal/descriptor_utils.cc to make library generation work.


This change is Reviewable

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cuiy0006 cuiy0006 marked this pull request as ready for review December 4, 2024 16:24
@cuiy0006 cuiy0006 requested review from a team as code owners December 4, 2024 16:24
@cuiy0006 cuiy0006 enabled auto-merge (squash) December 4, 2024 16:24
@cuiy0006 cuiy0006 merged commit 7411652 into googleapis:main Dec 4, 2024
74 checks passed
@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.00%. Comparing base (6026c70) to head (31d9c59).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14871      +/-   ##
==========================================
- Coverage   93.00%   93.00%   -0.01%     
==========================================
  Files        2351     2351              
  Lines      209479   209479              
==========================================
- Hits       194831   194830       -1     
- Misses      14648    14649       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuiy0006 cuiy0006 deleted the chore-update-googleapis-sha-circa-2024-11-28 branch December 4, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants