chore(bazel): get bazel 8 working #15042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devbww
reviewed
Mar 20, 2025
bazel/workspace0.bzl
Outdated
Comment on lines
146
to
150
| # protobuf message. No changes to `patches` should ever be | ||
| # committed to the main branch. | ||
| patch_tool = "patch", | ||
| patch_args = ["-p1"], | ||
| patches = [], | ||
| patch_args = ["-p1", "-l", "-n"], | ||
| patches = ["//bazel:googleapis.workspace.patch"], |
Contributor
There was a problem hiding this comment.
"No changes to patches should ever be committed to the main branch."
Member
Author
There was a problem hiding this comment.
Agreed. This is just a draft to test the changes before I attempt to upstream them to the googleapis repo.
Contributor
There was a problem hiding this comment.
I see. Good tactic then. Sorry for jumping the gun.
scotthart
commented
Mar 20, 2025
Member
Author
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 291 files reviewed, 1 unresolved discussion (waiting on @devbww)
bazel/workspace0.bzl
Outdated
Comment on lines
146
to
150
| # protobuf message. No changes to `patches` should ever be | ||
| # committed to the main branch. | ||
| patch_tool = "patch", | ||
| patch_args = ["-p1"], | ||
| patches = [], | ||
| patch_args = ["-p1", "-l", "-n"], | ||
| patches = ["//bazel:googleapis.workspace.patch"], |
Member
Author
There was a problem hiding this comment.
Agreed. This is just a draft to test the changes before I attempt to upstream them to the googleapis repo.
devbww
reviewed
Mar 20, 2025
Contributor
devbww
left a comment
devbww
left a comment
There was a problem hiding this comment.
Reviewed 1 of 291 files at r1.
Reviewable status: 1 of 291 files reviewed, 1 unresolved discussion (waiting on @scotthart)
bazel/workspace0.bzl
Outdated
Comment on lines
146
to
150
| # protobuf message. No changes to `patches` should ever be | ||
| # committed to the main branch. | ||
| patch_tool = "patch", | ||
| patch_args = ["-p1"], | ||
| patches = [], | ||
| patch_args = ["-p1", "-l", "-n"], | ||
| patches = ["//bazel:googleapis.workspace.patch"], |
Contributor
There was a problem hiding this comment.
I see. Good tactic then. Sorry for jumping the gun.
Member
Author
|
/gcbrun |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15042 +/- ##
======================================================
- Coverage 92.91% 92.91% -0.01%
======================================================
Files 2351 2351
Lines 210169 210174 +5
======================================================
+ Hits 195274 195275 +1
- Misses 14895 14899 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
/gcbrun |
scotthart
merged commit a416727
into
googleapis:prepare-for-v3.0.0
48 of 49 checks passed
scotthart
added a commit
to scotthart/google-cloud-cpp
that referenced
this pull request
Apr 11, 2025
* chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
to scotthart/google-cloud-cpp
that referenced
this pull request
Apr 11, 2025
* chore: update to protobuf v30 and remove cxx14 build * update grpc to v1.71.0 * use new abseil repo name * add repo_mapping for absl * disable bzlmod for bazel-targets build * combine zypper commands chore: update abseil to 20250127.1 (googleapis#15039) chore(ci): update api and abi for v3 (googleapis#15041) chore(bazel): get bazel 8 working (googleapis#15042) * chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
to scotthart/google-cloud-cpp
that referenced
this pull request
Apr 11, 2025
chore: update to protobuf v30 and remove cxx14 build (googleapis#15013) * chore: update to protobuf v30 and remove cxx14 build * update grpc to v1.71.0 * use new abseil repo name * add repo_mapping for absl * disable bzlmod for bazel-targets build * combine zypper commands chore: update abseil to 20250127.1 (googleapis#15039) chore(ci): update api and abi for v3 (googleapis#15041) chore(bazel): get bazel 8 working (googleapis#15042) * chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
to scotthart/google-cloud-cpp
that referenced
this pull request
Apr 11, 2025
chore: update to protobuf v30 and remove cxx14 build (googleapis#15013) * chore: update to protobuf v30 and remove cxx14 build * update grpc to v1.71.0 * use new abseil repo name * add repo_mapping for absl * disable bzlmod for bazel-targets build * combine zypper commands chore: update abseil to 20250127.1 (googleapis#15039) chore(ci): update api and abi for v3 (googleapis#15041) chore(bazel): get bazel 8 working (googleapis#15042) * chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
to scotthart/google-cloud-cpp
that referenced
this pull request
Apr 11, 2025
* chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
to scotthart/google-cloud-cpp
that referenced
this pull request
Apr 25, 2025
chore: update to protobuf v30 and remove cxx14 build (googleapis#15013) * chore: update to protobuf v30 and remove cxx14 build * update grpc to v1.71.0 * use new abseil repo name * add repo_mapping for absl * disable bzlmod for bazel-targets build * combine zypper commands chore: update abseil to 20250127.1 (googleapis#15039) chore(ci): update api and abi for v3 (googleapis#15041) chore(bazel): get bazel 8 working (googleapis#15042) * chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
to scotthart/google-cloud-cpp
that referenced
this pull request
Apr 25, 2025
* chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
that referenced
this pull request
May 27, 2025
chore: update to protobuf v30 and remove cxx14 build (#15013) * chore: update to protobuf v30 and remove cxx14 build * update grpc to v1.71.0 * use new abseil repo name * add repo_mapping for absl * disable bzlmod for bazel-targets build * combine zypper commands chore: update abseil to 20250127.1 (#15039) chore(ci): update api and abi for v3 (#15041) chore(bazel): get bazel 8 working (#15042) * chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
that referenced
this pull request
May 27, 2025
* chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
that referenced
this pull request
Jun 5, 2025
chore: update to protobuf v30 and remove cxx14 build (#15013) * chore: update to protobuf v30 and remove cxx14 build * update grpc to v1.71.0 * use new abseil repo name * add repo_mapping for absl * disable bzlmod for bazel-targets build * combine zypper commands chore: update abseil to 20250127.1 (#15039) chore(ci): update api and abi for v3 (#15041) chore(bazel): get bazel 8 working (#15042) * chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
that referenced
this pull request
Jun 5, 2025
* chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
that referenced
this pull request
Jul 9, 2025
chore: update to protobuf v30 and remove cxx14 build (#15013) * chore: update to protobuf v30 and remove cxx14 build * update grpc to v1.71.0 * use new abseil repo name * add repo_mapping for absl * disable bzlmod for bazel-targets build * combine zypper commands chore: update abseil to 20250127.1 (#15039) chore(ci): update api and abi for v3 (#15041) chore(bazel): get bazel 8 working (#15042) * chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
that referenced
this pull request
Jul 9, 2025
* chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
to scotthart/google-cloud-cpp
that referenced
this pull request
Aug 13, 2025
chore: update to protobuf v30 and remove cxx14 build (googleapis#15013) * chore: update to protobuf v30 and remove cxx14 build * update grpc to v1.71.0 * use new abseil repo name * add repo_mapping for absl * disable bzlmod for bazel-targets build * combine zypper commands chore: update abseil to 20250127.1 (googleapis#15039) chore(ci): update api and abi for v3 (googleapis#15041) chore(bazel): get bazel 8 working (googleapis#15042) * chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
scotthart
added a commit
to scotthart/google-cloud-cpp
that referenced
this pull request
Aug 13, 2025
* chore(bazel): get bazel 8 working * enable workspace where we disable bzlmod * patch googleapis BUILD.bazel when using workspace * check for null json * determine generation proto paths dynamically * bazel quickstart version has to be changed in two phases * update quickstart bazelrc to use c++17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is