impl(spanner): do Uuid to/from string conversions using absl::uint128 #15057
Conversation
Instead of processing the high and low 64 bits of the Uuid separately, just use the 128-bit value directly. Also simplify the Uuid tests. Fixes googleapis#15043.
|
/gcbrun |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15057 +/- ##
=======================================
Coverage 92.90% 92.91%
=======================================
Files 2354 2354
Lines 210374 210365 -9
=======================================
+ Hits 195443 195452 +9
+ Misses 14931 14913 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It looks like the cmake-oldest-deps build is old enough to not support the deduced-type `%v` specifier.
|
/gcbrun |
|
The tests don't look like they're operating as planned: Please assist. |
|
/gcbrun |
|
I don't know how/when you folks triage PRs these days, but it would be nice to get some attention. |
scotthart
left a comment
scotthart
left a comment
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @devbww)
Sorry about the delay, spinning lots of plates these days. |
2 participants
Instead of processing the high and low 64 bits of the Uuid separately, just use the 128-bit value directly.
Also simplify the Uuid tests.
Fixes #15043.
This change is