Skip to content

samples(storage): use istreambuf_iterator instead of istream_iterator in storage_object_samples #15059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddelgrosso1 merged 2 commits into from
Apr 17, 2025
Merged

samples(storage): use istreambuf_iterator instead of istream_iterator in storage_object_samples #15059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a23f19c
samples(storage): use istreambuf_iterator instead of istream_iterator…
eliasdaler Apr 1, 2025
312a93e
Merge branch 'main' into patch-1
ddelgrosso1 Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions google/cloud/storage/examples/storage_object_samples.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,8 +322,8 @@ void ReadObjectIntoMemory(google::cloud::storage::Client client,
[](gcs::Client client, std::string const& bucket_name,
std::string const& object_name) {
gcs::ObjectReadStream stream = client.ReadObject(bucket_name, object_name);
std::string buffer{std::istream_iterator<char>(stream),
std::istream_iterator<char>()};
std::string buffer{std::istreambuf_iterator<char>(stream),
std::istreambuf_iterator<char>()};
if (stream.bad()) throw google::cloud::Status(stream.status());

std::cout << "The object has " << buffer.size() << " characters\n";
Expand All @@ -340,7 +340,7 @@ void ReadObjectGzip(google::cloud::storage::Client client,
std::string const& object_name) {
auto is =
client.ReadObject(bucket_name, object_name, gcs::AcceptEncodingGzip());
auto const contents = std::string{std::istream_iterator<char>(is), {}};
auto const contents = std::string{std::istreambuf_iterator<char>(is), {}};
if (is.bad()) throw google::cloud::Status(is.status());
std::cout << "The object has " << contents.size() << " characters\n";
}
Expand Down
Loading