chore(storage): use designated initializers for client.cc/h files#15106
chore(storage): use designated initializers for client.cc/h files#15106Pulkit0110 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15106 +/- ##
=======================================
Coverage 92.90% 92.90%
=======================================
Files 2360 2360
Lines 211708 211712 +4
=======================================
+ Hits 196685 196699 +14
+ Misses 15023 15013 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for the PR, but unfortunately we won't be able to merge these changes at this time. Designated initializers are a c++20 feature (https://en.cppreference.com/w/cpp/language/aggregate_initialization). While compilers some times implement features prior to their standardization, in order to maintain portability, we cannot use them ahead of time. The silver lining is that this PR has brought to our attention that we do not have any CI builds that enable |
Formatted storage client.cc and client.h files to use designated initializers as per https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-designated-initializers.html#modernize-use-designated-initializers.
This change is