Skip to content

Conversation

@cuiy0006
Copy link
Contributor

@cuiy0006 cuiy0006 commented Apr 25, 2025

This change is Reviewable

@cuiy0006 cuiy0006 requested a review from a team as a code owner April 25, 2025 14:27
@cuiy0006 cuiy0006 enabled auto-merge (squash) April 25, 2025 14:27
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Operations mixin methods in the Spanner Instance Admin service are not being generated.

Reviewable status: 0 of 66 files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (a821661) to head (660c066).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15109   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files        2360     2360           
  Lines      211708   211708           
=======================================
+ Hits       196677   196693   +16     
+ Misses      15031    15015   -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cuiy0006
Copy link
Contributor Author

cuiy0006 commented Apr 25, 2025

It looks like the Operations mixin methods in the Spanner Instance Admin service are not being generated.

Reviewable status: 0 of 66 files reviewed, all discussions resolved

I think the major reason is,

the latest build (this pr) is using service yaml external/googleapis~/google/spanner/admin/instance/v1/spanner_admin_instance.yaml,

the previous build is using service yaml external/googleapis~/google/spanner/admin/instance/v1/spanner.yaml

It is caused by the change at googleapis/googleapis@45f440b

So I will say the removal of the operation mixins is expected.

Although I think it is service team's mistake not adding the api in apis, they even have the method overrides in the publishing.

@cuiy0006 cuiy0006 closed this Apr 29, 2025
auto-merge was automatically disabled April 29, 2025 14:03

Pull request was closed

@cuiy0006 cuiy0006 deleted the chore-update-googleapis-sha-circa-2025-04-25 branch June 10, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants