Skip to content

feat(storage): Make absl::cord constructor public in write_payload.h #15113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pulkit0110 merged 1 commit into from
Apr 30, 2025
Merged

feat(storage): Make absl::cord constructor public in write_payload.h #15113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion google/cloud/storage/async/write_payload.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ class WritePayload {
explicit WritePayload(std::vector<T> p)
: impl_(storage_internal::MakeCord(std::move(p))) {}

/// Creates a payload from @p impl.
explicit WritePayload(absl::Cord impl) : impl_(std::move(impl)) {}

/// Returns true if the payload has no data.
bool empty() const { return impl_.empty(); }

Expand All @@ -76,7 +79,6 @@ class WritePayload {

private:
friend struct storage_internal::WritePayloadImpl;
explicit WritePayload(absl::Cord impl) : impl_(std::move(impl)) {}

absl::Cord impl_;
};
Expand Down
Loading