Skip to content

Comments

samples(storage): add samples for soft delete objects#15133

Merged
shubham-up-47 merged 11 commits intogoogleapis:mainfrom
shubham-up-47:object_soft_delete
May 15, 2025
Merged

samples(storage): add samples for soft delete objects#15133
shubham-up-47 merged 11 commits intogoogleapis:mainfrom
shubham-up-47:object_soft_delete

Conversation

@shubham-up-47
Copy link
Contributor

@shubham-up-47 shubham-up-47 commented May 8, 2025 •
edited by scotthart
Loading

Add samples for object soft delete,

  • storage_list_soft_deleted_objects
  • storage_list_soft_deleted_object_versions
  • storage_restore_object

This change is Reviewable

@shubham-up-47 shubham-up-47 requested review from a team as code owners May 8, 2025 08:41
@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels May 8, 2025
@codecov
Copy link

codecov bot commented May 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (4055e08) to head (95d80fb).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15133   +/-   ##
=======================================
  Coverage   92.92%   92.93%           
=======================================
  Files        2391     2392    +1     
  Lines      214995   215083   +88     
=======================================
+ Hits       199791   199882   +91     
+ Misses      15204    15201    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ddelgrosso1
ddelgrosso1 approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shubham-up-47 shubham-up-47 merged commit 67bbff6 into googleapis:main May 15, 2025
77 of 79 checks passed
@shubham-up-47 shubham-up-47 deleted the object_soft_delete branch May 16, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shubham-up-47 @ddelgrosso1