impl(spanner): add support for Read Lock Mode in RW transactions#15235
Merged
diegomarquezp merged 18 commits intogoogleapis:mainfrom Nov 4, 2025
Merged
impl(spanner): add support for Read Lock Mode in RW transactions#15235diegomarquezp merged 18 commits intogoogleapis:mainfrom
diegomarquezp merged 18 commits intogoogleapis:mainfrom
Conversation
This adds support for Transaction_ReadWriteOptions_ReadLockMode by adding a constructor of ReadWriteOptions with a special enum, whose values can be "optimistic", "pessimistic" and "unspecified".
…uezp/google-cloud-cpp into spanner-read-lock-mode
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15235 +/- ##
==========================================
- Coverage 93.09% 93.08% -0.02%
==========================================
Files 2442 2442
Lines 224759 224818 +59
==========================================
+ Hits 209247 209277 +30
- Misses 15512 15541 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Pending: address issues pointed by checkers-pr and clang-tidy-pr |
devbww
reviewed
Jun 26, 2025
google/cloud/spanner/integration_tests/client_integration_test.cc
Outdated
Show resolved
Hide resolved
google/cloud/spanner/integration_tests/client_integration_test.cc
Outdated
Show resolved
Hide resolved
google/cloud/spanner/integration_tests/client_integration_test.cc
Outdated
Show resolved
Hide resolved
scotthart
approved these changes
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is