build(vcpkg): pin opentelemetry to 1.20.0#15459
Closed
diegomarquezp wants to merge 1 commit intogoogleapis:mainfrom
Closed
build(vcpkg): pin opentelemetry to 1.20.0#15459diegomarquezp wants to merge 1 commit intogoogleapis:mainfrom
diegomarquezp wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Version [v1.22.0](https://github.com/open-telemetry/opentelemetry-cpp/releases/tag/v1.22.0) of opentelemtry removes semantic_conversions.h, and my CMake job fails: ``` Installing 17/19 opentelemetry-cpp:x64-linux@1.22.0#1... ... /usr/local/google/home/diegomarquezp/google/google-cloud-cpp/google/cloud/internal/rest_opentelemetry.cc:26:10: fatal error: opentelemetry/trace/semantic_conventions.h: No such file or directory 26 | #include <opentelemetry/trace/semantic_conventions.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` This PR temporarily pins opentelemtry to the current version supported by `main`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15459 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 2403 2403
Lines 219553 219553
=======================================
+ Hits 204273 204276 +3
+ Misses 15280 15277 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version v1.22.0 of opentelemtry removes semantic_conversions.h, and my CMake job fails:
This PR temporarily pins opentelemtry to the current version supported by
main.This change is