feat(bigtable): add minimal Value class#15462
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15462 +/- ##
========================================
Coverage 93.04% 93.04%
========================================
Files 2403 2406 +3
Lines 219553 219730 +177
========================================
+ Hits 204273 204439 +166
- Misses 15280 15291 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I would leave full coverage as a separate task. I have brought some implementation from spanner not yet added to unit tests. |
scotthart
left a comment
There was a problem hiding this comment.
@scotthart reviewed 3 of 6 files at r1, all commit messages.
Reviewable status: 3 of 6 files reviewed, 3 unresolved discussions
google/cloud/bigtable/value.h line 21 at r4 (raw file):
#include "google/cloud/status_or.h" #include <google/bigtable/v2/types.pb.h> #include <google/protobuf/struct.pb.h>
We shouldn't need this type/header as bigtable doesn't use it in their protos.
google/cloud/bigtable/value.h line 129 at r4 (raw file):
* Use `operator<<` instead. */ friend void PrintTo(Value const& v, std::ostream* os) { *os << v; }
Let's either remove this now or add a TODO to make we don't forget.
google/cloud/bigtable/value.h line 199 at r4 (raw file):
google::bigtable::v2::Type type_; google::protobuf::Value value_;
For bigtable value_ is of type google::bigtable::v2::Value which is going to cause a cascade of changes.
diegomarquezp
left a comment
There was a problem hiding this comment.
Reviewable status: 3 of 6 files reviewed, 3 unresolved discussions (waiting on @scotthart)
google/cloud/bigtable/value.h line 21 at r4 (raw file):
Previously, scotthart (Scott Hart) wrote…
We shouldn't need this type/header as bigtable doesn't use it in their protos.
Done
google/cloud/bigtable/value.h line 129 at r4 (raw file):
Previously, scotthart (Scott Hart) wrote…
Let's either remove this now or add a TODO to make we don't forget.
Removed
google/cloud/bigtable/value.h line 199 at r4 (raw file):
Previously, scotthart (Scott Hart) wrote…
For bigtable
value_is of typegoogle::bigtable::v2::Valuewhich is going to cause a cascade of changes.
That makes a big difference, indeed. We are now using google::bigtable::v2::Value
scotthart
left a comment
There was a problem hiding this comment.
@scotthart reviewed 3 of 3 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @diegomarquezp)
Adds a Value class to represent a value of the
Typesproto.For now, it only supports
boolandoptionalin order to have the implementation covering all basic aspects usinggoogle/cloud/spanner/value*as a reference.This change is