-
Notifications
You must be signed in to change notification settings - Fork 435
impl(universe_domain): remove experimental from bazel target #15656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request completes a previous effort to remove experimental naming conventions by renaming the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly removes the experimental- prefix from the universe_domain Bazel target, reflecting its graduation to a stable feature. The changes update the target definition in the root BUILD.bazel file and all its usages across various test and demo build files. The changes are consistent, well-contained, and correctly applied. This is a good cleanup PR that aligns with the feature's maturity.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15656 +/- ##
=======================================
Coverage 93.10% 93.10%
=======================================
Files 2439 2439
Lines 223941 223941
=======================================
+ Hits 208493 208504 +11
+ Misses 15448 15437 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was overlooked in the previous PR that removed the ExperimentalTag params.