Skip to content

Conversation

@scotthart
Copy link
Member

This was overlooked in the previous PR that removed the ExperimentalTag params.

@scotthart scotthart requested review from a team as code owners October 23, 2025 20:59
@gemini-code-assist
Copy link

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes a previous effort to remove experimental naming conventions by renaming the experimental-universe_domain Bazel target to universe_domain. The change also updates all dependent build configurations to reflect this new target name, ensuring consistency and alignment with the stable status of the universe domain feature within the project's build system.

Highlights

  • Bazel Target Renaming: The cc_library Bazel target named experimental-universe_domain in the root BUILD.bazel file has been renamed to universe_domain. This change finalizes the removal of experimental tags, as indicated in the PR description.
  • Dependency Updates: All references to the previously named experimental-universe_domain target have been updated across various BUILD.bazel files, including those for storage tests, universe domain demos, and universe domain integration tests, to now correctly point to the universe_domain target.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the experimental- prefix from the universe_domain Bazel target, reflecting its graduation to a stable feature. The changes update the target definition in the root BUILD.bazel file and all its usages across various test and demo build files. The changes are consistent, well-contained, and correctly applied. This is a good cleanup PR that aligns with the feature's maturity.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.10%. Comparing base (1cbff5a) to head (c337ce4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15656   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files        2439     2439           
  Lines      223941   223941           
=======================================
+ Hits       208493   208504   +11     
+ Misses      15448    15437   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart merged commit 14ccd99 into googleapis:main Oct 27, 2025
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants