impl(bigtable): add string literal constructor to Bytes

[scotthart]

Lacking this constructor, Bytes("foo") would end up in the request proto as "foo\000" instead of "foo" as the null-terminator was being slurped in with the other constructors.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a specialized constructor to the Bytes class within the google::cloud::bigtable library. The change ensures that C-style string literals are correctly interpreted and converted into Bytes objects without inadvertently appending null-terminators, which previously caused data corruption when these objects were serialized into request protos. This enhancement provides more accurate and predictable behavior when working with string data.

Highlights

• New Constructor for Bytes: An explicit constructor Bytes(char const* bytes) has been added to the Bytes class.
• Correct String Literal Handling: This new constructor specifically addresses an issue where string literals like "foo" were incorrectly including a null-terminator (\000) when converted to Bytes objects, leading to "foo\000" instead of the intended "foo" in request protos.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new constructor for Bytes to correctly handle C-style string literals, preventing the inclusion of the null terminator. The implementation is correct and solves the issue described. However, the unit tests in google/cloud/bigtable/bytes_test.cc have not been updated to reflect this change. Specifically, the test cases for Bytes("") and Bytes("foo") in the Bytes, OutputStream test will now fail. Please update these tests to assert the new, correct behavior. I have also added a minor suggestion to improve the documentation for the new constructor.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.98%. Comparing base (a3f8ffb) to head (8081829).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15750      +/-   ##
==========================================
+ Coverage   92.97%   92.98%   +0.01%     
==========================================
  Files        2445     2445              
  Lines      226195   226196       +1     
==========================================
+ Hits       210297   210323      +26     
+ Misses      15898    15873      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mpeddada1]

Is it possible to have a unit test to verify the fix this change is aiming to make?

[scotthart]

The updates I had to make to the existing test is probably the only way to verify the new behavior.