Skip to content

impl(bigtable): cancel refresh_timer_ in QueryPlan destructor #15755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scotthart merged 2 commits into from
Nov 13, 2025
Merged

impl(bigtable): cancel refresh_timer_ in QueryPlan destructor #15755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
674bdaf
impl(bigtable): cancel refresh_timer_ in QueryPlan destructor
scotthart Nov 12, 2025
18a69c2
Merge branch 'main' into bigtable_query_plan_cancel_timer
scotthart Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions google/cloud/bigtable/internal/query_plan.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ std::shared_ptr<QueryPlan> QueryPlan::Create(
return plan;
}

QueryPlan::~QueryPlan() {
if (refresh_timer_.valid()) refresh_timer_.cancel();
}

void QueryPlan::Initialize() {
std::unique_lock<std::mutex> lock(mu_);
if (state_ == RefreshState::kDone) ScheduleRefresh(lock);
Expand Down
2 changes: 2 additions & 0 deletions google/cloud/bigtable/internal/query_plan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ class QueryPlan : public std::enable_shared_from_this<QueryPlan> {
StatusOr<google::bigtable::v2::PrepareQueryResponse> response,
RefreshFn fn, std::shared_ptr<Clock> clock = std::make_shared<Clock>());

~QueryPlan();

// Invalidates the current QueryPlan and triggers a refresh.
void Invalidate(Status status, std::string const& invalid_query_plan_id);

Expand Down