Skip to content

Comments

feat(bigtable): add validation for checksum in stream processing#15770

Merged
scotthart merged 7 commits intogoogleapis:mainfrom
mpeddada1:validate-checksum
Nov 18, 2025
Merged

feat(bigtable): add validation for checksum in stream processing#15770
scotthart merged 7 commits intogoogleapis:mainfrom
mpeddada1:validate-checksum

Conversation

@mpeddada1
Copy link
Collaborator

@mpeddada1 mpeddada1 commented Nov 17, 2025

With this change, we should also be able to address the ChecksumMismatch conformance test failure.

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Nov 17, 2025
@mpeddada1 mpeddada1 marked this pull request as ready for review November 17, 2025 05:38
@mpeddada1 mpeddada1 requested a review from a team as a code owner November 17, 2025 05:38
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 94.08284% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.94%. Comparing base (0f0a7cf) to head (f6e78a6).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/bigtable/internal/const_buffer.cc 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15770      +/-   ##
==========================================
- Coverage   92.95%   92.94%   -0.01%     
==========================================
  Files        2448     2453       +5     
  Lines      226434   226598     +164     
==========================================
+ Hits       210483   210618     +135     
- Misses      15951    15980      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all the new files created, update the Copyright year to 2025.

@scotthart
Copy link
Member

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces checksum validation for stream processing in Bigtable, which is a valuable addition for ensuring data integrity. The changes include new utility files for CRC32C calculation and buffer management, with a performance-aware implementation for CRC32C. The core validation logic is implemented in PartialResultSetSource, and the build files and tests have been updated accordingly. The tests are now more robust, using calculated checksums instead of hardcoded values, and a new test for checksum mismatches has been added. Overall, the changes are well-implemented. I have one suggestion to improve error handling consistency.

@scotthart scotthart merged commit 45a779e into googleapis:main Nov 18, 2025
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants