feat(bigtable): add validation for checksum in stream processing#15770
feat(bigtable): add validation for checksum in stream processing#15770scotthart merged 7 commits intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15770 +/- ##
==========================================
- Coverage 92.95% 92.94% -0.01%
==========================================
Files 2448 2453 +5
Lines 226434 226598 +164
==========================================
+ Hits 210483 210618 +135
- Misses 15951 15980 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
scotthart
left a comment
There was a problem hiding this comment.
For all the new files created, update the Copyright year to 2025.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces checksum validation for stream processing in Bigtable, which is a valuable addition for ensuring data integrity. The changes include new utility files for CRC32C calculation and buffer management, with a performance-aware implementation for CRC32C. The core validation logic is implemented in PartialResultSetSource, and the build files and tests have been updated accordingly. The tests are now more robust, using calculated checksums instead of hardcoded values, and a new test for checksum mismatches has been added. Overall, the changes are well-implemented. I have one suggestion to improve error handling consistency.
With this change, we should also be able to address the
ChecksumMismatchconformance test failure.