Skip to content

Comments

test(bigtable): implement ExecuteQuery_FailsOnTypeMismatch* tests#15772

Merged
scotthart merged 16 commits intogoogleapis:mainfrom
diegomarquezp:bigtable-sql/conformance-tests-2
Nov 18, 2025
Merged

test(bigtable): implement ExecuteQuery_FailsOnTypeMismatch* tests#15772
scotthart merged 16 commits intogoogleapis:mainfrom
diegomarquezp:bigtable-sql/conformance-tests-2

Conversation

@diegomarquezp
Copy link
Collaborator

  • test(bigtable): conform with ExecuteQuery_FailsOnTypeMismatch tests*
  • chore: clang-tidy

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 94.59459% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.94%. Comparing base (41ea3fc) to head (39580ca).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/bigtable/value.cc 91.81% 9 Missing ⚠️
...le/cloud/bigtable/internal/data_connection_impl.cc 60.00% 2 Missing ⚠️
...oud/bigtable/internal/partial_result_set_source.cc 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15772      +/-   ##
==========================================
- Coverage   92.95%   92.94%   -0.01%     
==========================================
  Files        2454     2454              
  Lines      226685   226903     +218     
==========================================
+ Hits       210721   210906     +185     
- Misses      15964    15997      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@diegomarquezp diegomarquezp added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2025
@diegomarquezp diegomarquezp marked this pull request as ready for review November 18, 2025 06:31
@diegomarquezp diegomarquezp requested a review from a team as a code owner November 18, 2025 06:31
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 18, 2025
@diegomarquezp diegomarquezp changed the title test(bigtable): conform with ExecuteQuery_FailsOnTypeMismatch* tests test(bigtable): implement ExecuteQuery_FailsOnTypeMismatch* tests Nov 18, 2025
Updated the list of skipped tests in run_conformance_tests_proxy_bazel.sh.
@diegomarquezp diegomarquezp marked this pull request as ready for review November 18, 2025 18:36
@scotthart scotthart merged commit 887d7d0 into googleapis:main Nov 18, 2025
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants