test(bigtable): enable ChecksumMismatch conformance test#15777
test(bigtable): enable ChecksumMismatch conformance test#15777mpeddada1 merged 2 commits intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @mpeddada1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the robustness of the Bigtable client by enabling a critical conformance test. Specifically, it re-activates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enables the ChecksumMismatch conformance test by removing it from a skip list and cleaning up a related comment. The changes are logical and achieve the stated goal. I have added one comment with a suggestion to improve the readability and maintainability of the shell script by refactoring a very long line.
| go test -v \ | ||
| -run "TestExecuteQuery|TestExecuteQuery_PlanRefresh$|TestExecuteQuery_PlanRefresh_WithMetadataChange|TestExecuteQuery_PlanRefresh_Retries|TestExecuteQuery_FailsOnSuccesfulStreamWithNoToken" \ | ||
| -skip "CloseClient|FailsOnEmptyMetadata|FailsOnExecuteQueryMetadata|FailsOnInvalidType|ChecksumMismatch|FailsOnTypeMismatch|FailsOnTypeMismatchWithinMap|FailsOnTypeMismatchWithinArray|FailsOnTypeMismatchWithinStruct|FailsOnStructMissingField|TestExecuteQuery_PlanRefresh_AfterResumeTokenCausesError|TestExecuteQuery_RetryTest_WithPlanRefresh|TestExecuteQuery_PlanRefresh_RespectsDeadline|TestExecuteQuery_PlanRefresh_RecoversAfterPermanentError" \ | ||
| -skip "CloseClient|FailsOnEmptyMetadata|FailsOnExecuteQueryMetadata|FailsOnInvalidType|FailsOnTypeMismatch|FailsOnTypeMismatchWithinMap|FailsOnTypeMismatchWithinArray|FailsOnTypeMismatchWithinStruct|FailsOnStructMissingField|TestExecuteQuery_PlanRefresh_AfterResumeTokenCausesError|TestExecuteQuery_RetryTest_WithPlanRefresh|TestExecuteQuery_PlanRefresh_RespectsDeadline|TestExecuteQuery_PlanRefresh_RecoversAfterPermanentError" \ |
There was a problem hiding this comment.
This line is extremely long (over 250 characters), which harms readability and maintainability. Consider refactoring this long list of skipped tests into a shell array to make it easier to manage.
For example:
local -a skip_tests=(
"CloseClient"
"FailsOnEmptyMetadata"
"FailsOnExecuteQueryMetadata"
# ... and so on for each test to skip
)
local skip_arg
skip_arg="$(IFS='|'; echo "${skip_tests[*]}")"
go test -v \
-run "..." \
-skip "${skip_arg}" \
...This approach makes the list of skipped tests much clearer and easier to modify.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15777 +/- ##
==========================================
- Coverage 92.95% 92.95% -0.01%
==========================================
Files 2454 2454
Lines 226685 226685
==========================================
- Hits 210721 210717 -4
- Misses 15964 15968 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.